-
Notifications
You must be signed in to change notification settings - Fork 3
Fps Profiler - save fps, cpu, gpu data to csv file #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: o3de-2409
Are you sure you want to change the base?
Conversation
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
: Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
…st to config Signed-off-by: Wojciech Czerski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for future: Avoid merging main/development back to your feature branch, since it creates strange structure in git graph and shows some of already reviewed changes from main branch as changes currently made. Consider usage of the git rebase instead
Overal work really nice and provides very useful data, great job! Although I left some comments related to design and one small regression with file paths
I would recommend removing Editor component since it doesn't have any editor specific operations, just reflection. Instead reflection for edit context can be added to game component (FPSProfileComponent).
Could you also explain definitions of the system components in this setup? Possibly other than defining interfaces? Because this is the only reason that i see to define system components in this setup. But you defined all of them as system and don't really know why. It would be great if you could clarify this
Gems/FPSProfiler/Code/Source/Tools/FPSProfilerEditorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/FPSProfiler/Code/Source/Tools/FPSProfilerEditorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/FPSProfiler/Code/Source/Tools/FPSProfilerEditorComponent.h
Outdated
Show resolved
Hide resolved
Gems/FPSProfiler/Code/Source/Configurations/FPSProfilerConfig.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
7902d3b
to
3ba5c4b
Compare
EDIT: Github automatically forces merge with the conflicted |
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, I left only some comments to improve minor things.
But I will point it once again. Try to avoid merging main branch to your feature branch. It really messes up git graph structure. Better practice in case of conflicts is to update your local repo to be up to date with the remote, pull latest commits from the main branch. git switch/checkout to your feature branch. Git rebase main and then resolve all conflicts on you local repo. When you arre done, push rebased changes to the feature branch by git push origin feature_branch --force-with-lease.
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
Signed-off-by: Wojciech Czerski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, very nice feature!
About
This PR introduces a game mode fps and memory statistics profiler that exports collected data into a
csv
file.Features
The Profiler has an EBus that can control profiling in runtime (start/stop/reset), save profiled data, change save path, and access current frame memory data or fps (avg, min, max). Works with
Lua
andScript Canvas
.Saved File Example
Editor Configuration
Possible Improvements
This can be extended to profile the editor data, for example, with exposed EBus functionality.