-
Notifications
You must be signed in to change notification settings - Fork 34
Supporting Jazzy distribution #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
I tested this PR on Ubuntu24.04 + ROS 2 Jazzy environment, but I encountered one error with
So, I changed these points, and it works successfully. (src/ros2cs/ros2cs_core/CMakeLists.txt) (row:31)
+ find_package( yaml-cpp REQUIRED)
....
(row:360~382)
set(ros2_standalone_libs
rcl
rcl_logging_spdlog
rcl_yaml_param_parser
rcpputils
rcutils
rmw
FastRTPS
rmw_fastrtps_cpp
CycloneDDS
rmw_cyclonedds_cpp
rmw_dds_common
rmw_implementation
rosidl_runtime_c
rosidl_typesupport_c
rosidl_typesupport_cpp
rosidl_typesupport_introspection_c
rosidl_typesupport_introspection_cpp
spdlog
tracetools
- yaml
+ yaml-cpp
tinyxml2
) |
Thank you @LegitYew0108 ! I confirmed yaml-cpp errors on standalone mode, and fixed it. |
Thank you for your work, I would like the maintainer to merge this PR. I've also tested this branch with Ros2ForUnity, and it works with my Jazzy environment (Ubuntu 24.04, ROS 2 Jazzy) Maybe the line of find_package is needed as @LegitYew0108 mentioned. + find_package(yaml-cpp REQUIRED) |
Dear Watanabe, Could you detail how you managed to get it work with your jazzy environment, do you have your own fork of Ros2ForUnity you might share ? Many thanks ! |
Here is my version of ros2-for-unity: RobotecAI/ros2-for-unity#125 |
Have you tried it ? Because in the ros2cs.repos you are not refering to your fork of ros2cs, so if I do pull the repos its doing : Do I only need to change the target of ros2cs.repo to your work ? Thats what I tried earlier and was facing other issues when importing in linux the standalone compiled one :
|
In this PR, I will introduce a support for Jazzy distribution. (Iron is not tested but I think it will work)
There are some changes:
rosidl_core
.rosidl_core
is newly introduced package in Create package rosidl_core_generators ros2/rosidl_defaults#22rosidl_get_typesupport_target
I tested this PR on my Ubuntu 24.04 + Unity 2022.3.15f1 + ROS 2 Jazzy environment.