Skip to content

Fix issue of filtering the properties while sharing profile #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −11
Open

Fix issue of filtering the properties while sharing profile #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions github/handlers/ExecuteBlockActionHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ export class ExecuteBlockActionHandler {
const storeData = {
profileParams: profileInteractionData as string[]
}
await this.persistence.updateByAssociation(new RocketChatAssociationRecord(RocketChatAssociationModel.MISC, "ProfileShareParam"), storeData);
await this.persistence.updateByAssociation(new RocketChatAssociationRecord(RocketChatAssociationModel.MISC, "ProfileShareParam"), storeData, true);
}
break;
}
Expand Down Expand Up @@ -671,13 +671,13 @@ export class ExecuteBlockActionHandler {
return context.getInteractionResponder().openModalViewResponse(shareProfileMod);
}
case ModalsEnum.APPROVE_PULL_REQUEST_ACTION:{

let value: string = context.getInteractionData().value as string;
let splittedValues = value?.split(" ");
let { user } = await context.getInteractionData();
let { room} = await context.getInteractionData();
let accessToken = await getAccessTokenForUser(this.read, user, this.app.oauth2Config) as IAuthData;

if(splittedValues.length==2 && accessToken?.token){
let data={
"repo" : splittedValues[0],
Expand Down Expand Up @@ -1026,8 +1026,8 @@ export class ExecuteBlockActionHandler {
}
}
break;
}
}

case ModalsEnum.GITHUB_LOGIN_ACTION :{
const {user, room} = context.getInteractionData();
if(room){
Expand Down Expand Up @@ -1073,7 +1073,7 @@ export class ExecuteBlockActionHandler {
});
return context.getInteractionResponder().openModalViewResponse(newIssueModal);
}

case ModalsEnum.TRIGGER_SEARCH_MODAL: {
const searchModal = await githubSearchModal({
modify: this.modify,
Expand All @@ -1096,13 +1096,13 @@ export class ExecuteBlockActionHandler {

const message = `You have unsubscribed from repository [${repo} Pull Request #${number}](https://github.com/${repo}/pull/${number})`;
await sendNotification(this.read, this.modify, user, room as IRoom, message);

}

case ModalsEnum.REMINDER_REMOVE_REPO_ACTION : {
const {value, user} = context.getInteractionData();
const {value, user} = context.getInteractionData();
await removeRepoReminder(this.read, this.persistence, value as string, user);

const updatedReminderModal = await reminderModal({modify: this.modify, read:this.read, persistence: this.persistence, http: this.http, uikitcontext: context});

return context.getInteractionResponder().updateModalViewResponse( updatedReminderModal);
Expand All @@ -1114,4 +1114,4 @@ export class ExecuteBlockActionHandler {

return context.getInteractionResponder().successResponse();
}
}
}