Skip to content

Conversation

@henit-chobisa
Copy link
Contributor

@henit-chobisa henit-chobisa commented Nov 13, 2022

Issue(s)

Closes #34

Acceptance Criteria fulfillment

  • Creation of Gist Modal for displaying the existing gist created by the User.
  • Creation of DualParamCommand and a new TrippleParamCommand for executing gist feature.
  • Making IGist and IGistFile Interfaces for structuring the data according to the SDK.
  • Adding method for fetching Gist in GithubSDK.

Proposed changes (including videos or screenshots)

image
image
image

  • Added gist dual and triple param command.
  • Added UserGistModal.

@henit-chobisa henit-chobisa changed the title Embedding gist feature feat: /gh gist for quicker sharing of Gist in chat. Nov 13, 2022
@henit-chobisa
Copy link
Contributor Author

@samad-yar-khan
Hey Samad, as discussed in the meet, I have tried to implement the most basic way for implementing Gist, kindly review.

@henit-chobisa henit-chobisa changed the title feat: /gh gist for quicker sharing of Gist in chat. [FEAT] /gh gist for quicker sharing of Gist in chat. Nov 14, 2022
@samad-yar-khan
Copy link
Contributor

@henit-chobisa Thankyou for putting in this work 🙌. I will review the code changes, test it once and let you know.

@henit-chobisa
Copy link
Contributor Author

@samad-yar-khan
Sure, The previous PR is the dependency of this one.

@samad-yar-khan
Copy link
Contributor

@henit-chobisa Can you please take a look at this and clean up this PR. Please mention me whenever its ready for a review.

@henit-chobisa
Copy link
Contributor Author

Sure, @samad-yar-khan, I try to resolve the PR

@samad-yar-khan
Copy link
Contributor

Hey @henit-chobisa is this PR still being worked on ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introducing Quick Gist feature for sharing Gist through Rocket Chat

2 participants