Skip to content

Conversation

@chinma-yyy
Copy link
Contributor

@chinma-yyy chinma-yyy commented Mar 7, 2023

Issue(s)

closes #26

Acceptance Criteria fulfillment

  • Expand code link on recieving a github code link in the rocket chat message

Proposed changes (including videos or screenshots)

image

Screenshot from 2023-03-16 00-02-24

So if the text contains code link then the checkPreMessageSentExtend first checks for the github link then executePreMessageSentExtend checks whether the link is of code link. The structure is like this because for #27 and #28 we can have similar checks in executePreMessageSentExtend. Then the handleCode link adds the attachment to the message.

Further comments

@chinma-yyy
Copy link
Contributor Author

Hey @samad-yar-khan this pr is ready for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand Code Links

1 participant