Feat: Add Dedicated Send Button to Quick Reply Contextual Bar#50
Open
KrishnaShuk wants to merge 1 commit intoRocketChat:mainfrom
Open
Feat: Add Dedicated Send Button to Quick Reply Contextual Bar#50KrishnaShuk wants to merge 1 commit intoRocketChat:mainfrom
KrishnaShuk wants to merge 1 commit intoRocketChat:mainfrom
Conversation
Author
|
@VipinDevelops i have added the separate send button in this PR. |
Collaborator
|
Share a video of complete working flow. |
Author
|
Hey @VipinDevelops , I have added the video showing the functionality of the send button. |
Collaborator
|
Can you show the working or edit and delete thing ? |
Author
|
@VipinDevelops I have updated the video. Now you can see all three functionalities - Send , Edit and Delete. |
iam-vipin
requested changes
Apr 6, 2025
Collaborator
iam-vipin
left a comment
iam-vipin
left a comment
There was a problem hiding this comment.
There is alot of spaces changes in PR making it hard to review.
| @@ -1,54 +1,54 @@ | |||
| { | |||
| "id": "e664d2cb-7beb-413a-837a-80fd840c387b", | |||
Collaborator
There was a problem hiding this comment.
can we remove this space chagnes ?
Collaborator
|
attached video is not playable |
Author
|
Okay i will make a new commit resolving the spaces issue and will attach a new video to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
#49
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Video
Uploading Screencast from 2025-03-23 09-27-27.webm…
The current implementation of the Quick Reply app buries the "Send" option within the kebab menu of the contextual bar. While functional, this requires extra steps for users to send replies, slowing down the experience—especially for frequent users—and making it less intuitive than a direct action.
This PR proposes adding a dedicated "Send" button directly in the contextual bar, positioned alongside the quick reply options. This change allows users to send their selected or typed reply instantly without navigating the kebab menu. To maintain a clean UI, the "Send" option will be removed from the kebab menu.