fix: Remove List footer to prevent thread load animation (#6579)

Author: diegolmello

app/views/RoomView/List/definitions.ts

@@ -22,7 +22,6 @@ export interface IListContainerProps {
 	renderRow: Function;
 	rid: string;
 	tmid?: string;
-	loading: boolean;
 	listRef: TListRef;
 	hideSystemMessages: string[];
 	showMessageInMainThread: boolean;

app/views/RoomView/List/index.tsx

@@ -1,13 +1,12 @@
 import React, { forwardRef, useImperativeHandle } from 'react';
 
-import ActivityIndicator from '../../../containers/ActivityIndicator';
 import { useDebounce } from '../../../lib/methods/helpers';
 import { EmptyRoom, List } from './components';
 import { IListContainerProps, IListContainerRef, IListProps } from './definitions';
 import { useMessages, useScroll } from './hooks';
 
 const ListContainer = forwardRef<IListContainerRef, IListContainerProps>(
-	({ rid, tmid, renderRow, showMessageInMainThread, serverVersion, hideSystemMessages, listRef, loading }, ref) => {
+	({ rid, tmid, renderRow, showMessageInMainThread, serverVersion, hideSystemMessages, listRef }, ref) => {
 		const [messages, messagesIds, fetchMessages] = useMessages({
 			rid,
 			tmid,
@@ -33,13 +32,6 @@ const ListContainer = forwardRef<IListContainerRef, IListContainerProps>(
 			cancelJumpToMessage
 		}));
 
-		const renderFooter = () => {
-			if (loading && rid) {
-				return <ActivityIndicator />;
-			}
-			return null;
-		};
-
 		const renderItem: IListProps['renderItem'] = ({ item, index }) => renderRow(item, messages[index + 1], highlightedMessageId);
 
 		return (
@@ -50,7 +42,6 @@ const ListContainer = forwardRef<IListContainerRef, IListContainerProps>(
 					data={messages}
 					renderItem={renderItem}
 					onEndReached={onEndReached}
-					ListFooterComponent={renderFooter}
 					onScrollToIndexFailed={handleScrollToIndexFailed}
 					viewabilityConfigCallbackPairs={viewabilityConfigCallbackPairs.current}
 					jumpToBottom={jumpToBottom}

app/views/RoomView/index.tsx

@@ -1497,7 +1497,7 @@ class RoomView extends React.Component<IRoomViewProps, IRoomViewState> {
 
 	render() {
 		console.count(`${this.constructor.name}.render calls`);
-		const { room, loading, action, selectedMessages, isAutocompleteVisible } = this.state;
+		const { room, action, selectedMessages, isAutocompleteVisible } = this.state;
 		const { user, baseUrl, theme, width, serverVersion, navigation, encryptionEnabled } = this.props;
 		const { rid, t } = room;
 		let bannerClosed;
@@ -1552,7 +1552,6 @@ class RoomView extends React.Component<IRoomViewProps, IRoomViewState> {
 						rid={rid}
 						tmid={this.tmid}
 						renderRow={this.renderItem}
-						loading={loading}
 						hideSystemMessages={this.hideSystemMessages}
 						showMessageInMainThread={user.showMessageInMainThread ?? false}
 						serverVersion={serverVersion}