Skip to content

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Dec 17, 2024

Proposed changes

Issue(s)

closes #5942

How to test or reproduce

Screenshots

Screenshot 2025-01-10 at 15 43 59
Screenshot 2025-01-10 at 15 43 50
Screenshot 2025-01-10 at 15 43 38
Screenshot 2025-01-10 at 15 43 01

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

CORE-848

@Rohit3523
Copy link
Contributor

This PR will also close #5942

@diegolmello diegolmello force-pushed the feat.multiple-files-render branch from 009223d to 8717d5a Compare January 10, 2025 17:57
@diegolmello diegolmello marked this pull request as ready for review January 10, 2025 19:03
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Rohit3523
Copy link
Contributor

I have noticed an issue: when we send the same images in different messages, only the image in the first message will open in the preview, not the ones in the rest. For example, if we send images one and two across three messages, we can tap and open the preview for the image in the first message, but not for the images in the second and third messages.

@Rohit3523
Copy link
Contributor

Fixed in #6093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple image attachments in one message do not work correctly

4 participants