fix: reset button text is not readable in room edit screen#6670
fix: reset button text is not readable in room edit screen#6670OtavioStasiak merged 4 commits intodevelopfrom
Conversation
WalkthroughThe Reset Button in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Comment |
app/views/RoomInfoEditView/index.tsx
Outdated
| <Button | ||
| backgroundColor={colors.buttonBackgroundSecondaryDefault} | ||
| title={I18n.t('RESET')} | ||
| color={colors.fontTitlesLabels} |
There was a problem hiding this comment.
I double-checked the Figma. Could you please use the colors.buttonFontSecondary token?
There was a problem hiding this comment.
Done but i can't see any difference ;-;
…etChat/Rocket.Chat.ReactNative into fix-reset-button-text-color
#6670) * Fix text color :) * Using buttonFontSecondary
Proposed changes
The Reset button text in the Room Edit screen is not readable in the light theme and this PR fix that issue :)
Issue(s)
N/A
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit