Skip to content

fix: reset button text is not readable in room edit screen#6670

Merged
OtavioStasiak merged 4 commits intodevelopfrom
fix-reset-button-text-color
Sep 23, 2025
Merged

fix: reset button text is not readable in room edit screen#6670
OtavioStasiak merged 4 commits intodevelopfrom
fix-reset-button-text-color

Conversation

@Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Sep 20, 2025

Proposed changes

The Reset button text in the Room Edit screen is not readable in the light theme and this PR fix that issue :)

Issue(s)

N/A

How to test or reproduce

Screenshots

Before After
Android Screenshot 2025-09-21 at 2 59 25 AM Screenshot 2025-09-21 at 3 00 26 AM
iOS Screenshot 2025-09-21 at 2 59 46 AM Screenshot 2025-09-21 at 3 00 43 AM
Android iOS
Dark Theme Screenshot 2025-09-21 at 3 01 53 AM Screenshot 2025-09-21 at 3 02 22 AM
Black Theme Screenshot 2025-09-21 at 3 02 53 AM Screenshot 2025-09-21 at 3 03 25 AM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Style
    • Updated the Reset button’s text and icon color to align with the app’s typography palette.
    • Improved contrast for better readability and accessibility.
    • Minor visual polish to bring the button in line with current design guidelines.
    • No functional, behavioral, or state management changes introduced.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 20, 2025

Walkthrough

The Reset Button in RoomInfoEditView now receives a color prop (colors.buttonFontSecondary) to set its text/icon color; no behavior, state, or control-flow changes were introduced.

Changes

Cohort / File(s) Change Summary
Button color prop update
app/views/RoomInfoEditView/index.tsx
Passed a color prop (colors.buttonFontSecondary) to the Reset Button to adjust its text/icon color; no functional logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • diegolmello
  • OtavioStasiak

Poem

I twitch my nose at a subtler key,
A Reset gleams in secondary melody—
No state disturbed, no flow unspun,
Just softer text beneath the sun.
Hop, click, and done. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change: fixing the unreadable Reset button text in the Room Edit screen; it is specific, concise, and uses the conventional commit-style prefix "fix:" so teammates can quickly understand the intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-reset-button-text-color

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3536e79 and 582ee68.

📒 Files selected for processing (1)
  • app/views/RoomInfoEditView/index.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/views/RoomInfoEditView/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: format
  • GitHub Check: ESLint and Test / run-eslint-and-test

Comment @coderabbitai help to get the list of available commands and usage tips.

<Button
backgroundColor={colors.buttonBackgroundSecondaryDefault}
title={I18n.t('RESET')}
color={colors.fontTitlesLabels}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked the Figma. Could you please use the colors.buttonFontSecondary token?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done but i can't see any difference ;-;

Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@OtavioStasiak OtavioStasiak merged commit f176f4b into develop Sep 23, 2025
6 of 16 checks passed
@OtavioStasiak OtavioStasiak deleted the fix-reset-button-text-color branch September 23, 2025 16:19
OtavioStasiak pushed a commit that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants