-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: upgrade to react native 81 and expo 54 #6875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
b2c221d
5e48723
261b939
b64c1eb
e1eaf31
1998f31
7e7f3d0
64a72f6
998504c
691fb63
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| buildscript { | ||
| ext { | ||
| buildToolsVersion = "35.0.0" | ||
| buildToolsVersion = "36.0.0" | ||
| minSdkVersion = 24 | ||
| compileSdkVersion = 35 | ||
| targetSdkVersion = 35 | ||
| compileSdkVersion = 36 | ||
| targetSdkVersion = 36 | ||
| ndkVersion = "27.1.12297006" | ||
| kotlinVersion = "2.0.21" | ||
| kotlinVersion = "2.1.20" | ||
|
Comment on lines
+3
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check React Native version in package.json
echo "=== React Native Version ==="
if [ -f "package.json" ]; then
rg '"react-native":\s*"[^"]*"' package.json -o
else
echo "package.json not found"
fi
# Check for Android-related configuration
echo -e "\n=== Android Configuration Files ==="
fd -e gradle . --max-depth 3 | head -20Repository: RocketChat/Rocket.Chat.ReactNative Length of output: 238 🌐 Web query:
💡 Result: Short answer: As of January 4, 2026, Android SDK 36 (Android 16 / "Baklava") is a stable, production SDK (Platform Stability reached; SDK Platform Revision 1 released). Google continues to ship quarterly minor updates (QPRs) and beta builds (QPR1–QPR3 betas/QPR images) but API 36 is stable for targeting and production use; developers should test against the latest QPR/beta images for device-specific fixes and large‑screen behavior changes. [1][2][3] Sources
🌐 Web query:
💡 Result: Short answer
Sources
🌐 Web query:
💡 Result: Short answer
Practical checklist
Sources
Verify Kotlin 2.1.20 compatibility with third-party native modules before merging. Android SDK 36 with 🤖 Prompt for AI Agents |
||
| kotlin_version = kotlinVersion | ||
| glideVersion = "4.11.0" | ||
| supportLibVersion = "28.0.0" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: Short answer: Yes — Gradle 8.14.3 can be used with Android API/SDK 36, provided you use a compatible Android Gradle Plugin (AGP) release (AGP 8.13.x is the AGP line that documents support for API level 36). Update the Gradle wrapper to 8.14.3 and use AGP 8.13.x (or a later AGP that lists API 36 support). [1][2] References:
🌐 Web query:
💡 Result: Short answer: Kotlin 2.1.20 is not officially supported on Gradle 8.14.3. Kotlin 2.1.20’s documented “fully supported” Gradle range ends at ~8.12.1, so Gradle 8.14.3 is newer than the officially supported maximum — it may work, but you can encounter deprecation warnings or breakage. [1][2] Recommendation: upgrade the Kotlin Gradle plugin to a 2.2.x (or later) KGP that lists Gradle 8.14 as supported (e.g., 2.2.20+ / 2.3.0 for fuller support), or use a Gradle version ≤ 8.12.1 if you must stay on Kotlin 2.1.20. [2][3] Sources:
Gradle 8.14.3 requires Kotlin 2.2.x or later — current Kotlin 2.1.20 is not officially supported. Gradle 8.14.3 is compatible with Android SDK 36 when using AGP 8.13.x or later. However, Kotlin 2.1.20 is only officially supported up to Gradle 8.12.1; using it with Gradle 8.14.3 may produce deprecation warnings or build failures. Either upgrade Kotlin to 2.2.x+ (which supports Gradle 8.14) or downgrade Gradle to 8.12.1 if staying on Kotlin 2.1.20. 🤖 Prompt for AI Agents |
||
| networkTimeout=10000 | ||
| validateDistributionUrl=true | ||
| zipStoreBase=GRADLE_USER_HOME | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| { | ||
| "name": "RocketChatRN" | ||
| "name": "RocketChatRN", | ||
| "plugins": ["@react-native-community/datetimepicker", "expo-web-browser"] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: RocketChat/Rocket.Chat.ReactNative
Length of output: 596
🏁 Script executed:
Repository: RocketChat/Rocket.Chat.ReactNative
Length of output: 1441
Add
usesCleartextTraffictomanifestPlaceholdersinandroid/app/build.gradle.The placeholder
${usesCleartextTraffic}is used inAndroidManifest.xmlbut is not defined in themanifestPlaceholdersmap. Updateandroid/app/build.gradleline 95 to include this variable:Without this definition, the build will fail or the placeholder will remain unexpanded in the manifest.
🤖 Prompt for AI Agents