Skip to content

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Jan 5, 2026

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1587

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Downgraded app version to 4.67.1.
    • Removed Firebase configuration files.
    • Removed debug build strings.
  • Chores

    • Updated build configurations and signing settings.
    • Applied dependency patches and optimizations.
    • Updated app server configuration.
  • UI Changes

    • Server display header is now static (no longer interactive).
    • Removed navigation option for manual server selection.

✏️ Tip: You can customize this high-level summary in your review settings.

diegolmello and others added 27 commits December 3, 2025 14:37
* feat: mark methods to change

* chore: deprecate methods

* feat: finished deprecated methods

* chore: code improvements

* fix: lint

* fix: type

* chore: code improvements

* chore: code improvements

* code improvements

* remove logs

* code improvements
* Added default value in useUserPreferences

* it was false ;-;

* added for auto play image
* feat: spotilight improvement and a11y announcement

* feat: new translation fields

* feat: improve announcement

* fix: nn translation

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: translation

* rollback search

* rollback search

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: aleksandernsilva <[email protected]>
Co-authored-by: Diego Mello <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

Caution

Review failed

Failed to post review comments

Walkthrough

This PR downgrades the app version from 4.68.0 to 4.67.1 across Android and iOS, removes Firebase configuration files, restructures server initialization logic to use appConfig, disables interactive server switching in the UI, adds keystore signing properties, updates iOS build provisioning configurations, and patches dependency libraries.

Changes

Cohort / File(s) Summary
Version Downgrade
package.json, android/app/build.gradle, ios/RocketChatRN/Info.plist, ios/ShareRocketChatRN/Info.plist, ios/RocketChatRN.xcodeproj/project.pbxproj
Updated version string from 4.68.0 to 4.67.1 across package.json, Android versionName, and iOS CFBundleShortVersionString/MARKETING_VERSION in all relevant configurations.
Firebase Configuration Removal
android/app/google-services.json, ios/GoogleService-Info.plist, ios/RocketChatRN.xcodeproj/project.pbxproj
Deleted android and iOS Firebase service configuration files; removed corresponding references from Xcode project build resources.
Android Build & Signing Configuration
android/gradle.properties, android/app/build.gradle
Added keystore signing properties (KEYSTORE, KEY_ALIAS, KEYSTORE_PASSWORD, KEY_PASSWORD), updated VERSIONCODE to 1, reorganized hermesEnabled property; removed debug string resources.
iOS Build & Provisioning Setup
ios/RocketChatRN.xcodeproj/project.pbxproj, ios/RocketChatRN/Info.plist, ios/ShareRocketChatRN/Info.plist
Added manual code signing with provisioning profiles across multiple targets (RocketChatRN, ShareRocketChatRN, NotificationService, Watch extensions); introduced Pods-defaults config file reference; added Check Pods Manifest.lock build phase; updated development team and provisioning profile specifiers.
App Configuration & Server Management
app.json, app/sagas/init.js, app/sagas/login.js
Added server property to app.json; refactored init.js to derive server from appConfig instead of scanning stored servers; modified logout flow in login.js to dispatch serverRequest using appConfig.server.
Navigation & UI Changes
app/stacks/OutsideStack.tsx, app/views/RoomsListView/components/Header.tsx
Disabled NewServerView screen in OutsideStack by commenting out imports and route; made server header non-interactive by removing TouchableOpacity and action sheet invocation.
Dependency Patches
patches/@discord+bottom-sheet+4.6.1.patch, patches/expo-file-system+18.1.7.patch
Updated BottomSheet animation duration config and removed accessibility props; changed OkHttpClient from private instance field to public static companion field with setter in expo-file-system.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Poem

🐰 Version down we go today, from sixty-eight to sixty-one,
Firebase keys are tucked away, appConfig's our chosen one,
Provisioning and signing set, servers managed new and bright,
A build so ready, headers static—everything feels right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title describes a merge operation, but the changeset shows a version downgrade (4.68.0 to 4.67.1) alongside significant configuration removals and single-server refactoring—not a straightforward merge of 4.68.0. Clarify whether this is a merge of 4.68.0 or a downgrade/refactor to 4.67.1 with single-server mode; update title to reflect the actual primary intent.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 4.68.0-single-server

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegolmello diegolmello changed the base branch from develop to single-server January 5, 2026 18:37
@diegolmello diegolmello merged commit 6a8ef6d into single-server Jan 5, 2026
5 of 7 checks passed
@diegolmello diegolmello deleted the 4.68.0-single-server branch January 5, 2026 18:38
@diegolmello diegolmello requested a deployment to experimental_android_build January 5, 2026 18:39 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to experimental_ios_build January 5, 2026 18:39 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to official_android_build January 5, 2026 18:39 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants