feat: Return departmentsAllowedToForward property in livechat/config endpoint#33060
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: a215a9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33060 +/- ##
===========================================
+ Coverage 59.27% 60.23% +0.95%
===========================================
Files 2820 2684 -136
Lines 67843 66163 -1680
Branches 15075 14634 -441
===========================================
- Hits 40216 39855 -361
+ Misses 24810 23513 -1297
+ Partials 2817 2795 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
…nto feat/livechat-config-departments-forward
…nto feat/livechat-config-departments-forward
|
MartinSchoeler
left a comment
There was a problem hiding this comment.
Is it possible to add some UI e2e tests? I know we didn't change any client files, but there are some behavior changes on the UI, I think we can add one to this file https://github.com/RocketChat/Rocket.Chat/blob/develop/apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-department.spec.ts or even a livechat API test to check if the widget api is respecting the fowarding limits implemented here
I was looking at the code/task, and I don't think that there are any changes in the UI, the PR only returns a new field so the frontend can use it to filter the departments correctly, no? |
Fair enough, dismissing this review
Proposed changes (including videos or screenshots)
departmentsAllowedToForwardproperty to departments returned by thelivechat/configendpoint (this is a requirement for a client improvement described in CORE-410)Issue(s)
Steps to test or reproduce
Further comments
CORE-652