Skip to content

fix(federation-v2): await bridge startup#33253

Merged
kodiakhq[bot] merged 12 commits intodevelopfrom
fix-bridge-startup-inconsistency
Dec 11, 2024
Merged

fix(federation-v2): await bridge startup#33253
kodiakhq[bot] merged 12 commits intodevelopfrom
fix-bridge-startup-inconsistency

Conversation

@debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Sep 11, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SUP-584

CORE-683

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: a14ed28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.31%. Comparing base (ac79766) to head (a14ed28).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #33253       +/-   ##
============================================
- Coverage    75.79%   60.31%   -15.49%     
============================================
  Files          511     2679     +2168     
  Lines        22132    65776    +43644     
  Branches      5394    14560     +9166     
============================================
+ Hits         16775    39670    +22895     
- Misses        4709    23320    +18611     
- Partials       648     2786     +2138     
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb debdutdeb marked this pull request as ready for review October 15, 2024 14:49
@debdutdeb debdutdeb requested a review from a team as a code owner October 15, 2024 14:49
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33253/
on branch gh-pages at 2024-12-11 09:49 UTC

Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changeset?

@MarcosSpessatto MarcosSpessatto added this to the 7.1.0 milestone Oct 22, 2024
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Oct 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 22, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 22, 2024
@casalsgh casalsgh modified the milestones: 7.1.0, 7.2.0 Nov 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 25, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 9, 2024
@casalsgh casalsgh added the stat: ready to merge PR tested and approved waiting for merge label Dec 11, 2024
@kodiakhq kodiakhq bot merged commit 6799f09 into develop Dec 11, 2024
@kodiakhq kodiakhq bot deleted the fix-bridge-startup-inconsistency branch December 11, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants