feat: Adds callout from cloud for subscription upgrade eligibility#33549
Merged
feat: Adds callout from cloud for subscription upgrade eligibility#33549
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3a49c7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33549 +/- ##
===========================================
- Coverage 75.83% 75.81% -0.03%
===========================================
Files 511 512 +1
Lines 22172 22205 +33
Branches 5397 5403 +6
===========================================
+ Hits 16814 16834 +20
- Misses 4710 4720 +10
- Partials 648 651 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Base automatically changed from
chore/bump-storybok-fuselage-ui-kit
to
develop
October 18, 2024 19:01
An error occurred while trying to automatically change base from
chore/bump-storybok-fuselage-ui-kit
to
develop
October 18, 2024 19:01
ggazzo
commented
Oct 19, 2024
apps/meteor/client/views/admin/subscription/SubscriptionPage.tsx
Outdated
Show resolved
Hide resolved
ggazzo
force-pushed
the
chore/bump-storybok-fuselage-ui-kit-cloud-surface
branch
2 times, most recently
from
986f721 to
1925762
Compare
gabriellsh
previously requested changes
Oct 23, 2024
apps/meteor/app/cloud/server/functions/syncWorkspace/syncCloudData.ts
Outdated
Show resolved
Hide resolved
ggazzo
force-pushed
the
chore/bump-storybok-fuselage-ui-kit-cloud-surface
branch
3 times, most recently
from
f416564 to
df8e534
Compare
dougfabris
force-pushed
the
chore/bump-storybok-fuselage-ui-kit-cloud-surface
branch
from
038d4fa to
7dc8e55
Compare
lucas-a-pelegrino
force-pushed
the
chore/bump-storybok-fuselage-ui-kit-cloud-surface
branch
from
4b8f3e6 to
69aa3d5
Compare
lucas-a-pelegrino
force-pushed
the
chore/bump-storybok-fuselage-ui-kit-cloud-surface
branch
from
69aa3d5 to
54e61b1
Compare
ggazzo
force-pushed
the
chore/bump-storybok-fuselage-ui-kit-cloud-surface
branch
9 times, most recently
from
ee63049 to
029541a
Compare
dougfabris
previously approved these changes
Dec 10, 2024
lucas-a-pelegrino
previously approved these changes
Dec 10, 2024
gabriellsh
requested changes
Dec 11, 2024
lucas-a-pelegrino
dismissed stale reviews from dougfabris and themself
via
6fd40dc
gabriellsh
previously requested changes
Dec 11, 2024
lucas-a-pelegrino
changed the title
KevLehman
requested changes
Dec 11, 2024
apps/meteor/app/cloud/server/functions/syncWorkspace/fetchWorkspaceSyncPayload.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/app/cloud/server/functions/syncWorkspace/syncCloudData.spec.ts
Show resolved
Hide resolved
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
barbarazanellaa
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
…ithub.com:RocketChat/Rocket.Chat into chore/bump-storybok-fuselage-ui-kit-cloud-surface
tassoevan
approved these changes
Dec 16, 2024
KevLehman
approved these changes
Dec 17, 2024
Merged
MartinSchoeler
pushed a commit
that referenced
this pull request
Dec 30, 2024
…33549) Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat> Co-authored-by: Lucas Pelegrino <lucas.pelegrino@rocket.chat> Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR aims to adapt the SubscriptionPage to be able to render the ui-kit Callout block properly, it also adds logic to fetch the callout information texts from the cloud and save it as a private setting, which will be used only internally by the application.
Issue(s)
CONN-365
Steps to test or reproduce
Further comments