chore: Remove openRoom client meteor method by aleksandernsilva · Pull Request #33833 · RocketChat/Rocket.Chat

aleksandernsilva · 2024-10-30T00:08:45Z

Proposed changes (including videos or screenshots)

This PR removes openRoom meteor method both on client and server.

Issue(s)

ARCH-1341

Steps to test or reproduce

Further comments

dionisio-bot · 2024-10-30T00:08:49Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-10-30T00:08:49Z

⚠️ No Changeset found

Latest commit: 4cb007f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-10-30T00:17:39Z

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33833/
on branch `gh-pages` at 2024-12-13 23:36 UTC

codecov · 2024-10-30T00:18:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (85980d7) to head (4cb007f).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33833   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648

Flag	Coverage Δ
unit	`75.79% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/server/methods/openRoom.ts

apps/meteor/app/api/server/v1/rooms.ts

apps/meteor/server/lib/openRoom.ts

packages/rest-typings/src/v1/rooms.ts

apps/meteor/server/lib/openRoom.ts

debdutdeb

comments above

dougfabris

LGTM!

apps/meteor/client/views/room/hooks/useOpenRoomMutation.tsx

apps/meteor/app/api/server/v1/channels.ts

apps/meteor/tests/end-to-end/api/rooms.ts

All requested changes have been addressed

yash-rajpal reviewed Oct 30, 2024

View reviewed changes

apps/meteor/server/methods/openRoom.ts Show resolved Hide resolved

aleksandernsilva force-pushed the chore/remove-openroom-method branch from 80e6842 to 95f3ac6 Compare October 30, 2024 13:15

debdutdeb reviewed Oct 31, 2024

View reviewed changes

apps/meteor/app/api/server/v1/rooms.ts Outdated Show resolved Hide resolved

debdutdeb reviewed Oct 31, 2024

View reviewed changes

apps/meteor/server/lib/openRoom.ts Outdated Show resolved Hide resolved

debdutdeb reviewed Oct 31, 2024

View reviewed changes

packages/rest-typings/src/v1/rooms.ts Show resolved Hide resolved

debdutdeb reviewed Oct 31, 2024

View reviewed changes

apps/meteor/server/lib/openRoom.ts Outdated Show resolved Hide resolved

debdutdeb previously requested changes Oct 31, 2024

View reviewed changes

aleksandernsilva force-pushed the chore/remove-openroom-method branch from 26e810e to cca3e77 Compare November 21, 2024 19:57

aleksandernsilva marked this pull request as ready for review November 22, 2024 00:31

aleksandernsilva requested review from a team as code owners November 22, 2024 00:31

aleksandernsilva requested a review from debdutdeb November 22, 2024 00:31

aleksandernsilva added this to the 7.2.0 milestone Nov 22, 2024

aleksandernsilva changed the title ~~chore: Remove openRoom meteor method~~ chore: Remove openRoom client meteor method Nov 22, 2024

aleksandernsilva force-pushed the chore/remove-openroom-method branch from b7cab56 to c2f7ea7 Compare November 22, 2024 13:48

dougfabris previously approved these changes Nov 25, 2024

View reviewed changes

dougfabris dismissed their stale review via f280497 December 4, 2024 19:17

tassoevan requested changes Dec 4, 2024

View reviewed changes

apps/meteor/client/views/room/hooks/useOpenRoomMutation.tsx Outdated Show resolved Hide resolved

apps/meteor/client/views/room/hooks/useOpenRoomMutation.tsx Outdated Show resolved Hide resolved

aleksandernsilva requested a review from tassoevan December 4, 2024 23:01

tassoevan previously approved these changes Dec 5, 2024

View reviewed changes

aleksandernsilva marked this pull request as draft December 5, 2024 13:16

aleksandernsilva dismissed tassoevan’s stale review via 4154ca9 December 5, 2024 14:12

aleksandernsilva marked this pull request as ready for review December 5, 2024 14:58

tassoevan previously approved these changes Dec 5, 2024

View reviewed changes

MarcosSpessatto suggested changes Dec 5, 2024

View reviewed changes

apps/meteor/app/api/server/v1/channels.ts Outdated Show resolved Hide resolved

aleksandernsilva marked this pull request as draft December 5, 2024 17:13

MarcosSpessatto suggested changes Dec 9, 2024

View reviewed changes

apps/meteor/tests/end-to-end/api/rooms.ts Show resolved Hide resolved

aleksandernsilva requested a review from MarcosSpessatto December 9, 2024 23:16

MarcosSpessatto approved these changes Dec 10, 2024

View reviewed changes

tassoevan approved these changes Dec 10, 2024

View reviewed changes

tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Dec 12, 2024

aleksandernsilva added 18 commits December 13, 2024 20:30

chore: remove openRoom client meteor method

0f3b6df

refactor: review requests

45971af

feat: added optmistic update

d92dd42

chore: removed rooms.open endpoint

6a36475

refactor: use open endpoints based on room type

835a280

fix: included voip rooms as valid in channels.open

4cc245d

chore: adjusted import order

0dfb946

refactor: changed to use updateSubscription

829bf6e

chore: implemented InvalidUserError

2cfc112

refactor: early throw if user is invalid

2dab2a3

chore: removed InvalidUserError

8bac5fc

refactor: removed throw and added userId as required param

b273dea

feat: added rooms.open endpoint

3a2a0e0

refactor: useOpenRoomMutation to use rooms.open endpoint

ebbe347

chore: removed methods import

9c2d0b8

chore: revert channels restriction

de3da92

chore: added minLength

f3545a9

test: added subscription assertion

4cb007f

tassoevan force-pushed the chore/remove-openroom-method branch from 9c76a55 to 4cb007f Compare December 13, 2024 23:30

aleksandernsilva added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Dec 15, 2024

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 15, 2024

kodiakhq bot merged commit 7f22793 into develop Dec 15, 2024

kodiakhq bot deleted the chore/remove-openroom-method branch December 15, 2024 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove openRoom client meteor method#33833

chore: Remove openRoom client meteor method#33833
kodiakhq[bot] merged 18 commits intodevelopfrom
chore/remove-openroom-method

aleksandernsilva commented Oct 30, 2024 •

edited by atlassian bot

Loading

Uh oh!

dionisio-bot bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

debdutdeb left a comment

Uh oh!

dougfabris left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

aleksandernsilva commented Oct 30, 2024 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

debdutdeb left a comment

Choose a reason for hiding this comment

Uh oh!

dougfabris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aleksandernsilva commented Oct 30, 2024 •

edited by atlassian bot

Loading

dionisio-bot bot commented Oct 30, 2024 •

edited

Loading

changeset-bot bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading