fix(UsersTable): mark remote users' registration as "Federated" instead of "Pending"#33873
Merged
kodiakhq[bot] merged 6 commits intodevelopfrom Dec 17, 2024
Merged
fix(UsersTable): mark remote users' registration as "Federated" instead of "Pending"#33873kodiakhq[bot] merged 6 commits intodevelopfrom
kodiakhq[bot] merged 6 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 94c2e04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33873 +/- ##
========================================
Coverage 75.83% 75.83%
========================================
Files 511 511
Lines 22172 22172
Branches 5397 5397
========================================
Hits 16814 16814
Misses 4710 4710
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
tiagoevanp
previously requested changes
Nov 4, 2024
Contributor
tiagoevanp
left a comment
tiagoevanp
left a comment
There was a problem hiding this comment.
Federated couldn't be Pending or Deactivated for any another reason? a federated user is always registered as federated for ever?
MarcosSpessatto
approved these changes
Dec 17, 2024
MarcosSpessatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
SUP-630
Steps to test or reproduce
Further comments