test: wait for composer send button to be enabled#33892
test: wait for composer send button to be enabled#33892aleksandernsilva wants to merge 1 commit intodevelopfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33892 +/- ##
========================================
Coverage 75.42% 75.42%
========================================
Files 493 493
Lines 21499 21499
Branches 5337 5337
========================================
Hits 16215 16215
Misses 4644 4644
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more. |
| await this.joinRoomIfNeeded(); | ||
| await this.page.waitForSelector('[name="msg"]:not([disabled])'); | ||
| await this.page.locator('[name="msg"]').fill(text); | ||
| await this.page.waitForSelector('button[aria-label="Send"]:not([disabled])'); |
There was a problem hiding this comment.
i think click also performs waitForSelector inside
Proposed changes (including videos or screenshots)
Issue(s)
FLAKY-652
Steps to test or reproduce
Further comments