Skip to content

test: wait for composer send button to be enabled#33892

Closed
aleksandernsilva wants to merge 1 commit intodevelopfrom
test/flaky-send-message
Closed

test: wait for composer send button to be enabled#33892
aleksandernsilva wants to merge 1 commit intodevelopfrom
test/flaky-send-message

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Nov 5, 2024

Proposed changes (including videos or screenshots)

Issue(s)

FLAKY-652

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 9f0338c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33892/
on branch gh-pages at 2024-11-05 21:07 UTC

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (dfd59e5) to head (9f0338c).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33892   +/-   ##
========================================
  Coverage    75.42%   75.42%           
========================================
  Files          493      493           
  Lines        21499    21499           
  Branches      5337     5337           
========================================
  Hits         16215    16215           
  Misses        4644     4644           
  Partials       640      640           
Flag Coverage Δ
unit 75.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

await this.joinRoomIfNeeded();
await this.page.waitForSelector('[name="msg"]:not([disabled])');
await this.page.locator('[name="msg"]').fill(text);
await this.page.waitForSelector('button[aria-label="Send"]:not([disabled])');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think click also performs waitForSelector inside

@aleksandernsilva aleksandernsilva deleted the test/flaky-send-message branch November 7, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants