Skip to content

chore: Update translation of view-livechat-rooms#34275

Merged
kodiakhq[bot] merged 5 commits intodevelopfrom
chore/update-translation
Dec 23, 2024
Merged

chore: Update translation of view-livechat-rooms#34275
kodiakhq[bot] merged 5 commits intodevelopfrom
chore/update-translation

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Dec 20, 2024

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-695

Steps to test or reproduce

Further comments

This setting is to view all livechat rooms, including the "current chats" page. While the other with the same name is view-l-room which is a permission that allows agents to see rooms they can serve.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 20, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: b5feb13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34275/
on branch gh-pages at 2024-12-23 16:58 UTC

@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (b4ce579) to head (b5feb13).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34275   +/-   ##
========================================
  Coverage    59.28%   59.28%           
========================================
  Files         2820     2820           
  Lines        67931    67931           
  Branches     15102    15102           
========================================
  Hits         40274    40274           
  Misses       24831    24831           
  Partials      2826     2826           
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review December 23, 2024 16:45
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Dec 23, 2024
@MartinSchoeler MartinSchoeler added this to the 7.3.0 milestone Dec 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 23, 2024
@kodiakhq kodiakhq bot merged commit b62b0a6 into develop Dec 23, 2024
@kodiakhq kodiakhq bot deleted the chore/update-translation branch December 23, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants