Skip to content

refactor: remove getOmniChatSortQuery dependency from livechat inquiry model#34491

Merged
ggazzo merged 3 commits intodevelopfrom
refactor-inquiry-model-dep
Dec 24, 2024
Merged

refactor: remove getOmniChatSortQuery dependency from livechat inquiry model#34491
ggazzo merged 3 commits intodevelopfrom
refactor-inquiry-model-dep

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 23, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Extracted from #34154
ARCH-1356

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: ac91a32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (d37433b) to head (ac91a32).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34491   +/-   ##
========================================
  Coverage    59.28%   59.28%           
========================================
  Files         2820     2820           
  Lines        67903    67904    +1     
  Branches     15094    15093    -1     
========================================
+ Hits         40254    40255    +1     
  Misses       24827    24827           
  Partials      2822     2822           
Flag Coverage Δ
unit 75.27% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34491/
on branch gh-pages at 2024-12-23 20:10 UTC

@sampaiodiego sampaiodiego marked this pull request as ready for review December 23, 2024 18:54
@sampaiodiego sampaiodiego requested review from a team as code owners December 23, 2024 18:54
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Dec 23, 2024
@sampaiodiego sampaiodiego added this to the 7.3.0 milestone Dec 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 23, 2024
@ggazzo ggazzo merged commit e5600bb into develop Dec 24, 2024
@ggazzo ggazzo deleted the refactor-inquiry-model-dep branch December 24, 2024 02:56
gabriellsh pushed a commit that referenced this pull request Dec 31, 2024
…y model (#34491)

Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants