You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposed changes (including videos or screenshots)
Regression for #35010 which was causing an issue when the same session was logging in and out multiple times.
The problem was that if the new log in was using the same sessionId as a previous one, that was probably logged out already, it was not creating a new session, so when the code was trying to to log out the session it couldn't find it, causing the error to be thrown.
I also changed to not throw an error if the session is not found.
W20250127-13:22:58.343(-3)? (STDERR) === UnHandledPromiseRejection ===
W20250127-13:22:58.344(-3)? (STDERR) Error: Session not found
W20250127-13:22:58.344(-3)? (STDERR) at app/statistics/server/lib/SAUMonitor.ts:151:11
W20250127-13:22:58.344(-3)? (STDERR) at processTicksAndRejections (node:internal/process/task_queues:105:5)
W20250127-13:22:58.344(-3)? (STDERR) ---------------------------------
W20250127-13:22:58.344(-3)? (STDERR) Errors like this can cause oplog processing errors.
W20250127-13:22:58.344(-3)? (STDERR) Setting EXIT_UNHANDLEDPROMISEREJECTION will cause the process to exit allowing your service to automatically restart the process
W20250127-13:22:58.344(-3)? (STDERR) Future node.js versions will automatically exit the process
W20250127-13:22:58.344(-3)? (STDERR) =================================
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stat: QA assuredMeans it has been tested and approved by a company insider
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Regression for #35010 which was causing an issue when the same session was logging in and out multiple times.
The problem was that if the new log in was using the same
sessionIdas a previous one, that was probably logged out already, it was not creating a new session, so when the code was trying to to log out the session it couldn't find it, causing the error to be thrown.I also changed to not throw an error if the session is not found.
Issue(s)
Steps to test or reproduce
Further comments