chore: replace suretype with zod#35154
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35154 +/- ##
========================================
Coverage 59.20% 59.20%
========================================
Files 2823 2823
Lines 67960 67960
Branches 15117 15117
========================================
Hits 40237 40237
Misses 24897 24897
Partials 2826 2826
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
left a comment
There was a problem hiding this comment.
please use an instance of Logger instead of console
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Proposed changes (including videos or screenshots)
suretypehasn't been updated in 2 years and is currently using libraries with known CVEs.zodis currently being maintained and seems to be a good choice for its replacement.workspaceLicensePayloadSchemawas altered to reflect Fleetcommand'sWorkspaceLicenseResponse(https://github.com/RocketChat/fleetcommand/blob/4fdfd62fc89f29858d0c2033340de8ae42c38916/models/provisionedLicense.go#L61C1-L68C1).workspaceCommPayloadSchemawas altered to reflect Fleetcommand'sWorkspaceCommsResponsePayload(https://github.com/RocketChat/fleetcommand/blob/4fdfd62fc89f29858d0c2033340de8ae42c38916/models/workspaceComms.go#L15), but still has previous values that aren't in the struct as "optional".workspaceClientPayloadSchemawas left unaltered since it's part of a legacy and deprecated part of the code.Issue(s)
https://rocketchat.atlassian.net/browse/VLN-98
Steps to test or reproduce
N/A
Further comments
N/A