Skip to content

fix: add missing Technology_Provider translation in setup wizard#36120

Closed
Kartikayy007 wants to merge 3 commits intoRocketChat:developfrom
Kartikayy007:fix/technology-provider-translation
Closed

fix: add missing Technology_Provider translation in setup wizard#36120
Kartikayy007 wants to merge 3 commits intoRocketChat:developfrom
Kartikayy007:fix/technology-provider-translation

Conversation

@Kartikayy007
Copy link

@Kartikayy007 Kartikayy007 commented Jun 2, 2025

Proposed changes

In the organization industry dropdown of the setup wizard, the "Technology_Provider" option was displaying with an underscore as "Technology_Provider" instead of the expected format "Technology Provider" (without underscore).

Fixes: #36119

Before:
Screenshot 2025-06-02 at 12 12 37 PM

After:
Screenshot 2025-06-02 at 12 19 31 PM

Issue(s)

Fixes: #36119

This PR fixes the display issue in the organization industry dropdown where "Technology_Provider" was showing with an underscore.

Steps to test or reproduce

  1. Navigate to the setup wizard.
  2. Go to the Organization Info step.
  3. Open the "Organization industry" dropdown.
  4. Verify that "Technology Provider" appears properly formatted without an underscore.

Further comments

The issue was caused by a missing translation entry in the English locale file (en.i18n.json). While other industry options like "Social_Network" and "Technology_Services" had proper translations, "Technology_Provider" was missing its translation entry, causing the system to fall back to displaying the raw i18n key with an underscore.

This PR adds the missing translation:

"Technology_Provider": "Technology Provider"

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 2, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2025

⚠️ No Changeset found

Latest commit: d26f553

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2025

CLA assistant check
All committers have signed the CLA.

@Kartikayy007
Copy link
Author

Please take a look @ggazzo thank you 🙂

Copy link
Contributor

@ricardogarim ricardogarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for contributing! really cool to see the community jumping in and participating in the project.

since this is a fix, it'd be great to add a changeset as described here.

once that's in, we can move forward and trigger the full CI run on your code.

let me know if anything's unclear or if you have questions!

@MartinSchoeler
Copy link
Member

Hello @Kartikayy007 Thanks for contributing to Rocket.Chat! Unfortunately these changes were already added in #36439

So I will be closing this PR.

@Kartikayy007
Copy link
Author

Hello @Kartikayy007 Thanks for contributing to Rocket.Chat! Unfortunately these changes were already added in #36439

So I will be closing this PR.

Are there any other issues to work upon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Inconsistent Naming in Industry Dropdown

5 participants