Skip to content

chore: Remove references to deprecated Modal.* components#36396

Merged
kodiakhq[bot] merged 2 commits intodevelopfrom
chore/remove-modal-namespace
Jul 11, 2025
Merged

chore: Remove references to deprecated Modal.* components#36396
kodiakhq[bot] merged 2 commits intodevelopfrom
chore/remove-modal-namespace

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 10, 2025

Proposed changes (including videos or screenshots)

It replaces namespaced Modal.* components (e.g. Modal.Backdrop) with their named counterparts (ModalBackdrop).

Issue(s)

ARCH-1706

Steps to test or reproduce

Further comments

It looks like the @deprecated annotation is missing at the final types, and there is no document suggesting this as the way to go forward.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 10, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2025

⚠️ No Changeset found

Latest commit: 97916f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36396/

Built to branch gh-pages at 2025-07-11 18:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 79.26421% with 62 lines in your changes missing coverage. Please review.

Project coverage is 65.36%. Comparing base (68426bd) to head (97916f8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36396      +/-   ##
===========================================
+ Coverage    65.30%   65.36%   +0.05%     
===========================================
  Files         3156     3156              
  Lines       103992   104133     +141     
  Branches     19893    19900       +7     
===========================================
+ Hits         67915    68062     +147     
+ Misses       33398    33388      -10     
- Partials      2679     2683       +4     
Flag Coverage Δ
e2e 58.39% <25.00%> (+<0.01%) ⬆️
unit 70.50% <79.46%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan marked this pull request as ready for review July 11, 2025 14:41
@tassoevan tassoevan requested a review from a team as a code owner July 11, 2025 14:41
@tassoevan tassoevan added this to the 7.9.0 milestone Jul 11, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Jul 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 11, 2025
@kodiakhq kodiakhq bot merged commit c40cbeb into develop Jul 11, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-modal-namespace branch July 11, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants