Skip to content

Revert "chore: Rooms store"#36434

Merged
ggazzo merged 1 commit intodevelopfrom
revert-36324-chore/rooms-store
Jul 16, 2025
Merged

Revert "chore: Rooms store"#36434
ggazzo merged 1 commit intodevelopfrom
revert-36324-chore/rooms-store

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 15, 2025

Reverts #36324

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 15, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2025

⚠️ No Changeset found

Latest commit: b2f1146

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo marked this pull request as ready for review July 16, 2025 00:02
@ggazzo ggazzo requested review from a team as code owners July 16, 2025 00:02
@ggazzo ggazzo merged commit 8c2bdb8 into develop Jul 16, 2025
9 of 10 checks passed
@ggazzo ggazzo deleted the revert-36324-chore/rooms-store branch July 16, 2025 00:02
@github-actions
Copy link
Contributor

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36434/

Built to branch gh-pages at 2025-07-16 00:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 30 lines in your changes missing coverage. Please review.

Project coverage is 65.00%. Comparing base (adfc1ac) to head (b2f1146).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36434      +/-   ##
===========================================
- Coverage    65.46%   65.00%   -0.47%     
===========================================
  Files         3168     3166       -2     
  Lines       104983   104796     -187     
  Branches     19994    19970      -24     
===========================================
- Hits         68730    68123     -607     
- Misses       33578    34006     +428     
+ Partials      2675     2667       -8     
Flag Coverage Δ
e2e 56.62% <81.63%> (-1.55%) ⬇️
unit 70.60% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant