Skip to content

chore: Don't use deprecated Modal reference#36448

Merged
kodiakhq[bot] merged 1 commit intodevelopfrom
chore/deprecated-modal
Jul 16, 2025
Merged

chore: Don't use deprecated Modal reference#36448
kodiakhq[bot] merged 1 commit intodevelopfrom
chore/deprecated-modal

Conversation

@MartinSchoeler
Copy link
Member

Proposed changes (including videos or screenshots)

Amends a small issue done in #36288

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 16, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2025

⚠️ No Changeset found

Latest commit: e35b582

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 16, 2025 16:42
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 16, 2025 16:42
@github-actions
Copy link
Contributor

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36448/

Built to branch gh-pages at 2025-07-16 16:46 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (48ffdfa) to head (e35b582).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36448      +/-   ##
===========================================
+ Coverage    65.50%   65.53%   +0.02%     
===========================================
  Files         3168     3168              
  Lines       105087   105098      +11     
  Branches     20010    20015       +5     
===========================================
+ Hits         68837    68871      +34     
+ Misses       33570    33553      -17     
+ Partials      2680     2674       -6     
Flag Coverage Δ
e2e 58.25% <ø> (+0.02%) ⬆️
unit 70.64% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan added this to the 7.9.0 milestone Jul 16, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2025
@kodiakhq kodiakhq bot merged commit 95072bb into develop Jul 16, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/deprecated-modal branch July 16, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants