fix: Intermittent error "Cannot read properties of undefined" when editing messages#36745
Merged
kodiakhq[bot] merged 17 commits intodevelopfrom Aug 28, 2025
Merged
fix: Intermittent error "Cannot read properties of undefined" when editing messages#36745kodiakhq[bot] merged 17 commits intodevelopfrom
kodiakhq[bot] merged 17 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 17eb9cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36745 +/- ##
===========================================
+ Coverage 66.13% 66.15% +0.01%
===========================================
Files 3303 3304 +1
Lines 110998 111027 +29
Branches 21051 21047 -4
===========================================
+ Hits 73411 73446 +35
+ Misses 34912 34909 -3
+ Partials 2675 2672 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
abhinavkrin
previously approved these changes
Aug 19, 2025
aleksandernsilva
requested changes
Aug 19, 2025
…update-message-weird-error
…t/Rocket.Chat into fix/update-message-weird-error
tassoevan
requested changes
Aug 21, 2025
tassoevan
previously approved these changes
Aug 27, 2025
…update-message-weird-error
aleksandernsilva
requested changes
Aug 27, 2025
441b7dd to
8045164
Compare
8045164 to
fc81cbb
Compare
aleksandernsilva
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR addresses a rare but disruptive issue where users encounter an error when attempting to edit their own messages. Specifically, the code attempts to read value from a race condition, resulting in an uncaught exception that dispatch a toast message with an error.
The solution provided is to apply "mutex" technique that is a synchronization primitive to protect shared resources from simultaneous access by multiple processes.
Issue(s)
Steps to test or reproduce
Further comments
CORE-895