regression: bad default value for new setting (sip port)

[pierre-lehnen-rc]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Bug Fixes

  • Corrected the default SIP server port to 5060 for VoIP and media calls, improving out-of-the-box connectivity with common SIP providers and PBXs.
  • Ensures connections use the correct port when none is explicitly configured, reducing registration and connection failures.

• Chores

  • Aligned related validation and fallback values to the new default port for consistency.
  • No other behavioral changes.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9a1e54e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Updated the SIP server port default and setting for VoIP from 5080 to 5060 in both the VoIP settings and media-call service configuration. No other logic, APIs, or exports changed.

Changes

Cohort / File(s)	Summary
VoIP SIP Port Update apps/meteor/ee/server/settings/voip.ts, apps/meteor/server/services/media-call/service.ts	Changed SIP server port default/invalidValue from 5080 to 5060; updates the configuration value and fallback port used when SIP integration is enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I tuned the ports with a twinkle, hop—
From 5080 to 5060, a tidy swap.
Little ears perk at each config tick,
SIP now listens where calls connect quick.
Thump-thump, I stamp this merge with cheer—
Carrots for logs, and clarity near! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title concisely identifies that this PR addresses a regression caused by an incorrect default SIP port setting and focuses on the core change without extraneous detail. It accurately reflects the main intent of updating the SIP port default value.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/media-call-sip-port-default

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bf35a0b and 9a1e54e.

📒 Files selected for processing (2)

• apps/meteor/ee/server/settings/voip.ts (1 hunks)
• apps/meteor/server/services/media-call/service.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: 📦 Build Packages
• GitHub Check: CodeQL-Build
• GitHub Check: Builds matrix rust bindings against alpine
• GitHub Check: CodeQL-Build

🔇 Additional comments (2)

apps/meteor/ee/server/settings/voip.ts (1)

77-82: LGTM! Corrected to standard SIP port.

The change from 5080 to 5060 is correct. Port 5060 is the IANA-assigned standard port for SIP (RFC 3261). Both the default value and invalidValue are updated consistently.

apps/meteor/server/services/media-call/service.ts (1)

91-94: LGTM! Fallback value now consistent with updated setting.

The fallback value correctly updated from 5080 to 5060, maintaining consistency with the default value defined in the VoIP settings. This ensures the service uses the standard SIP port (5060) when the setting is not explicitly configured.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

• Public repositories are always opted into early access features.
• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.38%. Comparing base (bf35a0b) to head (9a1e54e).
⚠️ Report is 5 commits behind head on release-7.11.0.

Additional details and impacted files

@@                Coverage Diff                 @@
##           release-7.11.0   #37099      +/-   ##
==================================================
- Coverage           67.39%   67.38%   -0.01%     
==================================================
  Files                3328     3328              
  Lines              113341   113341              
  Branches            20564    20563       -1     
==================================================
- Hits                76387    76379       -8     
- Misses              34348    34357       +9     
+ Partials             2606     2605       -1     

Flag	Coverage Δ
e2e	57.27% <ø> (-0.01%)	⬇️
unit	71.14% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.