chore: revert dep changed federations

[sampaiodiego]

Replace #37185

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Chores
  • Updated dependency configuration to include the federation SDK as a runtime dependency instead of a development or peer dependency.
  • Removed redundant peer dependency declaration and cleaned up development dependencies.
  • Improves runtime availability of federation features out of the box, reducing environment-specific setup and potential installation mismatches.
  • Enhances consistency across deployments by ensuring required components are bundled with the application.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: bd18a13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Reclassifies @rocket.chat/federation-sdk as a runtime dependency. Moves it from devDependencies and removes peerDependencies in ee/packages/federation-matrix/package.json and packages/core-services/package.json, adding it under dependencies at version 0.1.21.

Changes

Cohort / File(s)	Summary
Federation SDK dependency reclassification ee/packages/federation-matrix/package.json, packages/core-services/package.json	Move @rocket.chat/federation-sdk from devDependencies to dependencies ("0.1.21"); remove peerDependencies entry; delete devDependencies entry for the SDK.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• chore: update @rocket.chat/federation-sdk to 0.1.9 #37075 — Also changes @rocket.chat/federation-sdk in ee/packages/federation-matrix/package.json (version bump to 0.1.9).
• fix(federation): delete message #37112 — Modifies how @rocket.chat/federation-sdk is declared in ee/packages/federation-matrix/package.json.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• ggazzo

Poem

I nibbled on deps with gentle delight,
Moved the SDK where it runs every night.
No peers to fear, dev snacks set aside—
Dependencies stout, I hop with pride.
Thump-thump! The matrix hums just right. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title “chore: revert dep changed federations” is unclear and does not succinctly convey the primary change of moving the federation SDK from devDependencies to dependencies; the phrasing “changed federations” is vague and non-standard, making it hard to understand the intent at a glance.	Please update the title to clearly summarize the core change, for example: “chore: move @rocket.chat/federation-sdk from devDependencies to dependencies in federation-matrix”.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-dep-changed-federations

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5ceef6f and bd18a13.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (2)

• ee/packages/federation-matrix/package.json (1 hunks)
• packages/core-services/package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)

• GitHub Check: 🔨 Test UI (EE) / MongoDB 7.0 [legacy watchers] (2/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 7.0 [legacy watchers] (1/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (3/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (5/5) - Alpine (Official)
• GitHub Check: 🔨 Test API (EE) / MongoDB 5.0 (1/1) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (1/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 7.0 [legacy watchers] (5/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (CE) / MongoDB 7.0 (3/4) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 7.0 [legacy watchers] (4/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (CE) / MongoDB 7.0 (1/4) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (4/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 5.0 (2/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (EE) / MongoDB 7.0 [legacy watchers] (3/5) - Alpine (Official)
• GitHub Check: 🔨 Test UI (CE) / MongoDB 7.0 (2/4) - Alpine (Official)
• GitHub Check: 🔨 Test UI (CE) / MongoDB 7.0 (4/4) - Alpine (Official)
• GitHub Check: 🔨 Test UI (CE) / MongoDB 5.0 (3/4) - Alpine (Official)
• GitHub Check: 🔨 Test UI (CE) / MongoDB 5.0 (1/4) - Alpine (Official)
• GitHub Check: 🔨 Test UI (CE) / MongoDB 5.0 (4/4) - Alpine (Official)
• GitHub Check: 🔨 Test UI (CE) / MongoDB 5.0 (2/4) - Alpine (Official)
• GitHub Check: 🔨 Test API (CE) / MongoDB 5.0 (1/1) - Alpine (Official)
• GitHub Check: 🔨 Test API (CE) / MongoDB 7.0 (1/1) - Alpine (Official)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.45%. Comparing base (5ceef6f) to head (bd18a13).
⚠️ Report is 2 commits behind head on release-7.11.0.

Additional details and impacted files

@@               Coverage Diff               @@
##           release-7.11.0   #37186   +/-   ##
===============================================
  Coverage           67.45%   67.45%           
===============================================
  Files                3329     3329           
  Lines              113381   113381           
  Branches            20573    20578    +5     
===============================================
+ Hits                76477    76481    +4     
+ Misses              34306    34301    -5     
- Partials             2598     2599    +1     

Flag	Coverage Δ
e2e	57.28% <ø> (ø)
unit	71.23% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR reverts dependency changes for the federation SDK, moving @rocket.chat/federation-sdk from peer dependencies back to regular dependencies and removing peer dependency declarations.

• Moved @rocket.chat/federation-sdk from devDependencies to dependencies in both packages
• Removed peerDependencies sections that declared the federation SDK as peer dependencies

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
packages/core-services/package.json	Moved federation SDK from devDependencies to dependencies and removed peerDependencies section
ee/packages/federation-matrix/package.json	Moved federation SDK from devDependencies to dependencies and removed peerDependencies section

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}