Skip to content

Conversation

@Anshumancanrock
Copy link
Contributor

@Anshumancanrock Anshumancanrock commented Nov 2, 2025

Proposed changes (including videos or screenshots)

This PR fixes a React warning that appears when creating a new Email Inbox in the Administration panel. The warning "A component is changing an uncontrolled input to be controlled" was logged to the console when users typed into the Sender Info, Description, or Department fields for the first time.

Closes #37366

Steps to test or reproduce

  1. Navigate to Administration > Email Inbox in the admin panel
  2. Click the "New" button in the top-right corner
  3. Open the browser's developer console (F12 → Console tab)
  4. Click on any of the text fields: "Sender Info", "Description" or "Department"
  5. Type a single character
  6. Verify that no React warning appears in the console

Summary by CodeRabbit

  • Bug Fixes

    • Ensured email inbox form fields (description, sender information, department) consistently default to empty values so settings load and save predictably.
  • Chores

    • Build workflow updated to skip manifest generation and related steps unless an image is being published, reducing unnecessary CI work.

✏️ Tip: You can customize this high-level summary in your review settings.

@Anshumancanrock Anshumancanrock requested a review from a team as a code owner November 2, 2025 21:09
@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2025

⚠️ No Changeset found

Latest commit: b7f66e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 2, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 2, 2025

Walkthrough

EmailInboxForm.tsx now ensures text fields (description, senderInfo, department) default to empty strings when inboxData is missing those properties. The GitHub Actions workflow step for manifest inspection and related commands is wrapped in a conditional that runs only when publish-image is true.

Changes

Cohort / File(s) Summary
Form field initialization fix
apps/meteor/client/views/admin/emailInbox/EmailInboxForm.tsx
Coalesce description, senderInfo, and department defaults to "" when inboxData lacks them to keep inputs controlled on initial render.
CI manifest conditional
.github/actions/build-docker/action.yml
Wraps manifest inspection, SERVICE_SUFFIX computation, /tmp/manifests creation, Digest read, FULL_IMAGE derivation, docker manifest inspect, and manifest printing/saving inside if publish-image so these steps run only when publishing.

Sequence Diagram(s)

(omitted — changes are simple and do not introduce a new multi-component sequential flow)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰🌿 I nudged a field from undefined to light,
Now every keystroke stays gentle and right.
In CI I hopped, made manifest steps tame,
Two tiny fixes — the barn's not the same! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The changes include modifications to .github/actions/build-docker/action.yml that are unrelated to the linked issue #37366, which focuses solely on fixing the React warning in EmailInboxForm. Remove or separate the Docker build workflow changes; they should be addressed in a different PR as they are out of scope for fixing the React warning in EmailInboxForm.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing uncontrolled inputs becoming controlled in EmailInboxForm by coalescing undefined values to empty strings.
Linked Issues check ✅ Passed The PR successfully addresses the main requirement from issue #37366: ensuring text input fields (Sender Info, Description, Department) are initialized as controlled components with empty string defaults to prevent React warnings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Anshumancanrock Anshumancanrock changed the title fix: React Warning: Uncontrolled input is changing to controlled in E… fix: React Warning: Uncontrolled input is changing to controlled in EmailInboxForm Nov 2, 2025
@dougfabris dougfabris added this to the 7.13.0 milestone Nov 3, 2025
@dougfabris dougfabris changed the title fix: React Warning: Uncontrolled input is changing to controlled in EmailInboxForm fix: Uncontrolled input is changing to controlled in EmailInboxForm Nov 13, 2025
@Anshumancanrock
Copy link
Contributor Author

Hi, just checking if there’s anything I can improve or update in this PR.
Happy to make changes if needed.

@scuciatto scuciatto modified the milestones: 7.13.0, 7.14.0 Nov 19, 2025
@Anshumancanrock Anshumancanrock changed the title fix: Uncontrolled input is changing to controlled in EmailInboxForm fix: React Warning: Uncontrolled input is changing to controlled in EmailInboxForm Dec 3, 2025
@Anshumancanrock
Copy link
Contributor Author

@scuciatto Could you please review this one as well?

@dougfabris dougfabris changed the title fix: React Warning: Uncontrolled input is changing to controlled in EmailInboxForm chore: Uncontrolled input changing to controlled in EmailInboxForm Dec 18, 2025
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Dec 18, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 18, 2025
dougfabris
dougfabris previously approved these changes Dec 18, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 18, 2025
@scuciatto scuciatto removed the stat: QA assured Means it has been tested and approved by a company insider label Dec 18, 2025
@scuciatto scuciatto removed this from the 7.14.0 milestone Dec 18, 2025
@dougfabris dougfabris added this to the 8.1.0 milestone Dec 25, 2025
@dougfabris dougfabris requested a review from a team as a code owner December 25, 2025 14:27
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between df71c61 and 42a8718.

📒 Files selected for processing (1)
  • .github/actions/build-docker/action.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: CodeQL-Build

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.68%. Comparing base (cbcff00) to head (b7f66e7).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37367      +/-   ##
===========================================
+ Coverage    70.66%   70.68%   +0.01%     
===========================================
  Files         3143     3143              
  Lines       108661   108664       +3     
  Branches     19529    19560      +31     
===========================================
+ Hits         76790    76811      +21     
+ Misses       29868    29853      -15     
+ Partials      2003     2000       -3     
Flag Coverage Δ
e2e 60.21% <100.00%> (+0.03%) ⬆️
e2e-api 48.52% <ø> (+0.05%) ⬆️
unit 71.77% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris removed the request for review from a team January 5, 2026 16:40
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jan 5, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 5, 2026
@kodiakhq kodiakhq bot merged commit b801150 into RocketChat:develop Jan 7, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React Warning: Uncontrolled input is changing to controlled in EmailInboxForm

3 participants