-
Notifications
You must be signed in to change notification settings - Fork 12.9k
chore: Uncontrolled input changing to controlled in EmailInboxForm #37367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Looks like this PR is ready to merge! 🎉 |
WalkthroughEmailInboxForm.tsx now ensures text fields (description, senderInfo, department) default to empty strings when inboxData is missing those properties. The GitHub Actions workflow step for manifest inspection and related commands is wrapped in a conditional that runs only when Changes
Sequence Diagram(s)(omitted — changes are simple and do not introduce a new multi-component sequential flow) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EmailInboxForm
|
Hi, just checking if there’s anything I can improve or update in this PR. |
EmailInboxForm|
@scuciatto Could you please review this one as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/actions/build-docker/action.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37367 +/- ##
===========================================
+ Coverage 70.66% 70.68% +0.01%
===========================================
Files 3143 3143
Lines 108661 108664 +3
Branches 19529 19560 +31
===========================================
+ Hits 76790 76811 +21
+ Misses 29868 29853 -15
+ Partials 2003 2000 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
42a8718 to
d5d0f4b
Compare
Proposed changes (including videos or screenshots)
This PR fixes a React warning that appears when creating a new Email Inbox in the Administration panel. The warning "A component is changing an uncontrolled input to be controlled" was logged to the console when users typed into the
Sender Info,Description, orDepartmentfields for the first time.Closes #37366
Steps to test or reproduce
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.