Skip to content

fix: Webhook script compilation failure #38048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kalpana-chavhan wants to merge 3 commits into from
+34 −55
Closed

fix: Webhook script compilation failure #38048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2129237
fix: webhook script compilation failure with modern JS
Kalpana-chavhan Jan 3, 2026
a7c5fe1
fix: refactor integration script compilation to be atomic and remove …
Kalpana-chavhan Jan 3, 2026
8a42091
refactor: address review bot feedback on dead code and atomic updates
Kalpana-chavhan Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/meteor/app/integrations/server/methods/incoming/addIncomingIntegration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ export const addIncomingIntegration = async (userId: string, integration: INewIn
} catch (e) {
integrationData.scriptCompiled = undefined;
integrationData.scriptError = e instanceof Error ? _.pick(e, 'name', 'message', 'stack') : undefined;

// Surfacing the error to the UI to prevent saving a broken integration
throw new Meteor.Error(
'error-invalid-script',
`Compilation Error: ${e instanceof Error ? e.message : 'Unknown error'}`,
);
}
}

Expand Down
82 changes: 43 additions & 39 deletions apps/meteor/app/integrations/server/methods/incoming/updateIncomingIntegration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,48 +82,52 @@ export const updateIncomingIntegration = async (
});
}

const isFrozen = isScriptEngineFrozen(scriptEngine);

if (!isFrozen) {
let scriptCompiled: string | undefined;
let scriptError: Pick<Error, 'name' | 'message' | 'stack'> | undefined;

if (integration.scriptEnabled === true && integration.script && integration.script.trim() !== '') {
try {
let babelOptions = Babel.getDefaultOptions({ runtime: false });
babelOptions = _.extend(babelOptions, { compact: true, minified: true, comments: false });

scriptCompiled = Babel.compile(integration.script, babelOptions).code;
scriptError = undefined;
await Integrations.updateOne(
{ _id: integrationId },
{
$set: {
scriptCompiled,
},
$unset: { scriptError: 1 as const },
},
);
} catch (e) {
scriptCompiled = undefined;
if (e instanceof Error) {
const { name, message, stack } = e;
scriptError = { name, message, stack };
}
await Integrations.updateOne(
{ _id: integrationId },
{
$set: {
scriptError,
},
$unset: {
scriptCompiled: 1 as const,
},
},
);
const isFrozen = isScriptEngineFrozen(scriptEngine);

if (!isFrozen) {
let scriptCompiled: string | undefined;
let scriptError: Pick<Error, 'name' | 'message' | 'stack'> | undefined;

if (integration.scriptEnabled === true && integration.script && integration.script.trim() !== '') {
try {
let babelOptions = Babel.getDefaultOptions({ runtime: false });
babelOptions = _.extend(babelOptions, { compact: true, minified: true, comments: false });

scriptCompiled = Babel.compile(integration.script, babelOptions).code;
scriptError = undefined;

await Integrations.updateOne(
{ _id: integrationId },
{
$set: { scriptCompiled },
$unset: { scriptError: 1 as const },
},
);
} catch (e) {
scriptCompiled = undefined;
if (e instanceof Error) {
const { name, message, stack } = e;
scriptError = { name, message, stack };
}

await Integrations.updateOne(
{ _id: integrationId },
{
$set: { scriptError },
$unset: { scriptCompiled: 1 as const },
},
);

// This prevents the "silent failure" and notifies the user
throw new Meteor.Error('error-invalid-script', `Compilation Error: ${e instanceof Error ? e.message : 'Unknown error'}`);
}
}
}

// The loop MUST stay outside the script processing logic
for await (let channel of channels) {
// ... channel validation logic ...
}

for await (let channel of channels) {
const channelType = channel[0];
Expand Down
1 change: 1 addition & 0 deletions apps/meteor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"Firefox ESR"
],
"dependencies": {
"@babel/plugin-syntax-nullish-coalescing-operator": "^7.8.3",
"@babel/runtime": "~7.28.4",
"@bugsnag/js": "~7.20.2",
"@bugsnag/plugin-react": "~7.19.0",
Expand Down