regression(federation): use `send_leave` version 2 by ggazzo · Pull Request #38066 · RocketChat/Rocket.Chat

ggazzo · 2026-01-05T21:09:46Z

https://rocketchat.atlassian.net/browse/FB-137

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Release Notes

Chores
- Updated federation SDK dependency to version 0.3.8 across packages for consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…e package.json files and yarn.lock

dionisio-bot · 2026-01-05T21:09:50Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2026-01-05T21:09:50Z

⚠️ No Changeset found

Latest commit: 9d9befd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-01-05T21:09:54Z

Walkthrough

The @rocket.chat/federation-sdk dependency is updated from version 0.3.7 to 0.3.8 across three package.json files. This version bump addresses issues with federated invite handling, specifically enabling the ability to reject federated invites without encountering 404 errors.

Changes

Cohort / File(s)	Summary
Federation SDK Dependency Bump `apps/meteor/package.json`, `ee/packages/federation-matrix/package.json`, `packages/core-services/package.json`	`@rocket.chat/federation-sdk` updated from `0.3.7` → `0.3.8` across three modules

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

chore: update @rocket.chat/federation-sdk to 0.1.9 #37075: Updates the same @rocket.chat/federation-sdk dependency across multiple package.json files
chore: add federation-sdk as dependency for meteor #37268: Introduces the @rocket.chat/federation-sdk dependency to apps/meteor/package.json
regression(federation): mongo url, dms etc #37653: Also bumps @rocket.chat/federation-sdk in the same package files

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

sampaiodiego

Poem

🐰 A federation fix hops through the night,
SDK bumped from point-seven's plight,
Invites rejected without a 404 fright,
Three little files all polished bright,
Federation federation, now feels just right! 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The PR title mentions 'send_leave' version 2, but the changes only show federation-sdk dependency updates with no version-specific implementation details visible.	Clarify whether 'send_leave' version 2 refers to a feature within the federation-sdk 0.3.8 update or if the title accurately describes the actual code changes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	The PR updates federation-sdk to 0.3.8 which should address the FB-137 issue about rejecting federated invites failing with 404 errors.
Out of Scope Changes check	✅ Passed	All changes are confined to updating the @rocket.chat/federation-sdk dependency across package.json files, directly related to fixing the federated invite rejection issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch regression/send_leav

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9c225b7 and 9d9befd.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (3)

apps/meteor/package.json
ee/packages/federation-matrix/package.json
packages/core-services/package.json

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: sampaiodiego
Repo: RocketChat/Rocket.Chat PR: 37532
File: ee/packages/federation-matrix/src/FederationMatrix.ts:920-927
Timestamp: 2025-12-09T20:01:07.355Z
Learning: In Rocket.Chat's federation invite handling (ee/packages/federation-matrix/src/FederationMatrix.ts), when a user rejects an invite via federationSDK.rejectInvite(), the subscription cleanup happens automatically through an event-driven flow: Matrix emits a leave event back, which is processed by handleLeave() in ee/packages/federation-matrix/src/events/member.ts, and that function calls Room.performUserRemoval() to clean up the subscription. No explicit cleanup is needed in the reject branch of handleInvite() because the leave event handler takes care of it.
<!-- </add_learning>

Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37377
File: apps/meteor/ee/server/hooks/federation/index.ts:86-88
Timestamp: 2025-11-04T16:49:19.107Z
Learning: In Rocket.Chat's federation system (apps/meteor/ee/server/hooks/federation/), permission checks follow two distinct patterns: (1) User-initiated federation actions (creating rooms, adding users to federated rooms, joining from invites) should throw MeteorError to inform users they lack 'access-federation' permission. (2) Remote server-initiated federation events should silently skip/ignore when users lack permission. The beforeAddUserToRoom hook only executes for local user-initiated actions, so throwing an error there is correct. Remote federation events are handled separately by the federation Matrix package with silent skipping logic.

Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37205
File: ee/packages/federation-matrix/src/FederationMatrix.ts:296-301
Timestamp: 2025-10-28T16:53:42.761Z
Learning: In the Rocket.Chat federation-matrix integration (ee/packages/federation-matrix/), the createRoom method from rocket.chat/federation-sdk will support a 4-argument signature (userId, roomName, visibility, displayName) in newer versions. Code using this 4-argument call is forward-compatible with planned library updates and should not be flagged as an error.

Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37205
File: ee/packages/federation-matrix/src/FederationMatrix.ts:296-301
Timestamp: 2025-10-28T16:53:42.761Z
Learning: In the Rocket.Chat federation-matrix integration (ee/packages/federation-matrix/), the createRoom method from rocket.chat/federation-sdk will support a 4-argument signature (userId, roomName, visibility, displayName) in newer versions. Code using this 4-argument call is forward-compatible with planned library updates and should not be flagged as an error.

Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

📚 Learning: 2025-09-19T15:15:04.642Z

Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

apps/meteor/package.json
packages/core-services/package.json
ee/packages/federation-matrix/package.json

📚 Learning: 2025-10-28T16:53:42.761Z

Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37205
File: ee/packages/federation-matrix/src/FederationMatrix.ts:296-301
Timestamp: 2025-10-28T16:53:42.761Z
Learning: In the Rocket.Chat federation-matrix integration (ee/packages/federation-matrix/), the createRoom method from rocket.chat/federation-sdk will support a 4-argument signature (userId, roomName, visibility, displayName) in newer versions. Code using this 4-argument call is forward-compatible with planned library updates and should not be flagged as an error.

Applied to files:

apps/meteor/package.json
packages/core-services/package.json
ee/packages/federation-matrix/package.json

📚 Learning: 2025-11-04T16:49:19.107Z

Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37377
File: apps/meteor/ee/server/hooks/federation/index.ts:86-88
Timestamp: 2025-11-04T16:49:19.107Z
Learning: In Rocket.Chat's federation system (apps/meteor/ee/server/hooks/federation/), permission checks follow two distinct patterns: (1) User-initiated federation actions (creating rooms, adding users to federated rooms, joining from invites) should throw MeteorError to inform users they lack 'access-federation' permission. (2) Remote server-initiated federation events should silently skip/ignore when users lack permission. The beforeAddUserToRoom hook only executes for local user-initiated actions, so throwing an error there is correct. Remote federation events are handled separately by the federation Matrix package with silent skipping logic.

Applied to files:

apps/meteor/package.json

📚 Learning: 2025-11-05T21:04:35.787Z

Learnt from: sampaiodiego
Repo: RocketChat/Rocket.Chat PR: 37357
File: ee/packages/federation-matrix/src/setup.ts:103-120
Timestamp: 2025-11-05T21:04:35.787Z
Learning: In Rocket.Chat's federation-matrix setup (ee/packages/federation-matrix/src/setup.ts and apps/meteor/ee/server/startup/federation.ts), configureFederationMatrixSettings does not need to be called before setupFederationMatrix. The SDK's init() establishes infrastructure (database, event handlers, APIs) first, and the configuration can be applied later via settings watchers before actual federation events are processed. The config only matters when events actually occur, at which point all infrastructure is already configured.

Applied to files:

ee/packages/federation-matrix/package.json

🔇 Additional comments (3)

packages/core-services/package.json (1)

20-20: Consistent version bump applied.

The update to @rocket.chat/federation-sdk version 0.3.8 is consistent with the changes in apps/meteor/package.json and ee/packages/federation-matrix/package.json.

apps/meteor/package.json (1)

102-102: Consistent version bump applied.

The update to @rocket.chat/federation-sdk version 0.3.8 is consistent with the changes in packages/core-services/package.json and ee/packages/federation-matrix/package.json.

ee/packages/federation-matrix/package.json (1)

25-25: The send_leave v2 endpoint is already implemented; however, federation-sdk 0.3.8 release details cannot be publicly verified.

The version bump to 0.3.8 is present across all three packages. The send_leave v2 endpoint at /v2/send_leave/:roomId/:eventId is confirmed to be implemented. The federation-matrix CHANGELOG (0.0.9-rc.0) documents a related fix in PR #37791: "Fixes an issue where cases of invites that were canceled or disinvited were not being handled." However, published release notes for @rocket.chat/federation-sdk 0.3.8 are not publicly available, making it impossible to confirm that the external SDK version contains the specific fixes mentioned without access to internal federation-sdk documentation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-05T21:25:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.66%. Comparing base (9c225b7) to head (9d9befd).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.0.0   #38066      +/-   ##
=================================================
+ Coverage          70.61%   70.66%   +0.04%     
=================================================
  Files               3145     3145              
  Lines             108726   108726              
  Branches           19516    19551      +35     
=================================================
+ Hits               76782    76833      +51     
+ Misses             29945    29893      -52     
- Partials            1999     2000       +1

Flag	Coverage Δ
e2e	`60.17% <ø> (-0.02%)`	⬇️
e2e-api	`47.43% <ø> (-0.07%)`	⬇️
unit	`71.80% <ø> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-05T21:35:34Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.1GiB	0B	+1.1GiB
rocketchat	355MiB	0B	+355MiB
omnichannel-transcript-service	132MiB	0B	+132MiB
queue-worker-service	132MiB	0B	+132MiB
ddp-streamer-service	126MiB	0B	+126MiB
account-service	113MiB	0B	+113MiB
authorization-service	111MiB	0B	+111MiB
presence-service	111MiB	0B	+111MiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "01/06 23:30 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.4GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.1GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-38066
Baseline: develop
Timestamp: 2026-01-06 23:30:54 UTC
Historical data points: 30

Updated: Tue, 06 Jan 2026 23:30:55 GMT

cubic-dev-ai

No issues found across 4 files

chore: update @rocket.chat/federation-sdk to version 0.3.8 in multipl…

afa80e1

…e package.json files and yarn.lock

ggazzo added this to the 8.0.0 milestone Jan 5, 2026

Merge branch 'release-8.0.0' into regression/send_leav

9d9befd

ggazzo marked this pull request as ready for review January 7, 2026 00:40

cubic-dev-ai bot reviewed Jan 7, 2026

View reviewed changes

scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jan 7, 2026

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 7, 2026

aleksandernsilva approved these changes Jan 7, 2026

View reviewed changes

kodiakhq bot merged commit f7a9778 into release-8.0.0 Jan 7, 2026
80 of 82 checks passed

kodiakhq bot deleted the regression/send_leav branch January 7, 2026 11:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression(federation): use `send_leave` version 2#38066

regression(federation): use `send_leave` version 2#38066
kodiakhq[bot] merged 2 commits intorelease-8.0.0from
regression/send_leav

ggazzo commented Jan 5, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ggazzo commented Jan 5, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Release Notes

Uh oh!

dionisio-bot bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ggazzo commented Jan 5, 2026 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Jan 5, 2026 •

edited

Loading

changeset-bot bot commented Jan 5, 2026 •

edited

Loading

coderabbitai bot commented Jan 5, 2026 •

edited

Loading

codecov bot commented Jan 5, 2026 •

edited

Loading

github-actions bot commented Jan 5, 2026 •

edited

Loading