Skip to content

fix: show error state with retry when video conference block fails to load #38828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KumarHarshit3603 wants to merge 8 commits into
base: develop
Choose a base branch
from
+31 −3
Open

fix: show error state with retry when video conference block fails to load #38828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5658736
video-conf fix
KumarHarshit3603 Feb 19, 2026
b047817
Merge branch 'RocketChat:develop' into video-conf
KumarHarshit3603 Feb 19, 2026
46cc6ac
minor fixes
KumarHarshit3603 Feb 20, 2026
54b2212
Merge branch 'develop' into video-conf
KumarHarshit3603 Feb 25, 2026
3d1fcdd
Merge branch 'develop' into video-conf
KumarHarshit3603 Feb 25, 2026
8bc895f
Merge branch 'RocketChat:develop' into video-conf
KumarHarshit3603 Feb 28, 2026
22ca4f3
solved minor issues
KumarHarshit3603 Feb 28, 2026
2a063de
solved issues
KumarHarshit3603 Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions packages/fuselage-ui-kit/src/blocks/VideoConferenceBlock/VideoConferenceBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { getUserDisplayName, VideoConferenceStatus } from '@rocket.chat/core-typings';
import { Box, States, StatesAction, StatesActions, StatesIcon, StatesSubtitle, StatesTitle } from '@rocket.chat/fuselage';
import { useGoToRoom, useSetting, useTranslation, useUserId, useUserPreference } from '@rocket.chat/ui-contexts';
import type * as UiKit from '@rocket.chat/ui-kit';
import {
Expand Down Expand Up @@ -27,6 +28,8 @@ type VideoConferenceBlockProps = BlockProps<UiKit.VideoConferenceBlock>;

const MAX_USERS = 3;

const getErrorMessage = (error: unknown): string | undefined => (error instanceof Error ? error.message : undefined);

const VideoConferenceBlock = ({ block }: VideoConferenceBlockProps): ReactElement => {
const t = useTranslation();
const { callId, appId = 'videoconf-core' } = block;
Expand Down Expand Up @@ -109,11 +112,33 @@ const VideoConferenceBlock = ({ block }: VideoConferenceBlockProps): ReactElemen
: t('joined');
}, [displayAvatars, t, result.data?.users.length]);

if (result.isPending || result.isError) {
// TODO: error handling
if (result.isPending) {
return <VideoConfMessageSkeleton />;
}

if (result.isError) {
const errorMessage = getErrorMessage(result.error);

return (
<VideoConfMessage>
<VideoConfMessageRow>
<VideoConfMessageContent>
<Box display='flex' flexDirection='column' alignItems='center'>
<States>
<StatesIcon name='warning' variation='danger' />
<StatesTitle>{t('Something_went_wrong')}</StatesTitle>
<StatesSubtitle>{errorMessage ?? t('Unable_to_retrieve_data')}</StatesSubtitle>
<StatesActions>
<StatesAction onClick={() => result.refetch()}>{t('Retry')}</StatesAction>
</StatesActions>
</States>
</Box>
</VideoConfMessageContent>
</VideoConfMessageRow>
</VideoConfMessage>
);
}

const { data } = result;
const isUserCaller = data.createdBy._id === userId;

Expand Down
5 changes: 4 additions & 1 deletion packages/fuselage-ui-kit/src/blocks/VideoConferenceBlock/hooks/useVideoConfData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import type { VideoConference, VideoConferenceCapabilities } from '@rocket.chat/core-typings';
import { useEndpoint } from '@rocket.chat/ui-contexts';
import { useQuery } from '@tanstack/react-query';

type VideoConfInfo = VideoConference & { capabilities: VideoConferenceCapabilities };

export const useVideoConfData = ({ callId }: { callId: string }) => {
const getVideoConfInfo = useEndpoint('GET', '/v1/video-conference.info');

return useQuery({
return useQuery<VideoConfInfo, Error>({
queryKey: ['video-conference', callId],
queryFn: () => getVideoConfInfo({ callId }),
staleTime: Infinity,
Expand Down