fix(dataExport): Handle empty emails array TypeError

apps/meteor/server/lib/dataExport/sendViaEmail.spec.ts

@@ -0,0 +1,88 @@
+import { expect } from 'chai';
+import proxyquire from 'proxyquire';
+import Sinon from 'sinon';
+
+const modelsMock = {
+    Users: {
+        findUsersByUsernames: (usernames: string[]) => ({
+            toArray: async () =>
+                usernames
+                    .map((username) => {
+                        if (username === 'user_valid') {
+                            return { _id: '1', username: 'user_valid', emails: [{ address: 'valid@example.com' }] };
+                        }
+                        if (username === 'user_empty_emails') {
+                            return { _id: '2', username: 'user_empty_emails', emails: [] };
+                        }
+                        if (username === 'user_no_emails') {
+                            return { _id: '3', username: 'user_no_emails' }; // undefined emails array
+                        }
+                        return null;
+                    })
+                    .filter(Boolean),
+        }),
+    },
+    Messages: {
+        findByRoomIdAndMessageIds: () => ({
+            toArray: async () => [],
+        }),
+    },
+};
+
+const mailerMock = {
+    send: Sinon.stub().resolves(),
+    checkAddressFormat: () => true,
+};
+
+const mockMoment = function () {
+    return {
+        locale: () => ({ format: () => '12:00' }),
+    };
+};
+
+const { sendViaEmail } = proxyquire.load('./sendViaEmail.ts', {
+    '@rocket.chat/models': modelsMock,
+    '../../../app/mailer/server/api': { Mailer: mailerMock },
+    '../../../app/settings/server': {
+        settings: {
+            get: () => 'noreply@rocketchat.test',
+        },
+    },
+    '../../../app/ui-utils/server': {
+        Message: { parse: () => '' },
+    },
+    '../getMomentLocale': {
+        getMomentLocale: async () => null,
+    },
+});
+
+describe('sendViaEmail', () => {
+    beforeEach(() => {
+        mailerMock.send.resetHistory();
+    });
+
+    it('should process users even if some have empty or undefined emails arrays', async () => {
+        const reqData = {
+            rid: 'GENERAL',
+            toUsers: ['user_valid', 'user_empty_emails', 'user_no_emails'],
+            toEmails: ['extra@example.com'],
+            subject: 'Test Export',
+            messages: [],
+            language: 'en',
+        };
+
+        const executorUser = { _id: 'admin', username: 'admin', emails: [{ address: 'admin@example.com' }] };
+
+        // Should NOT throw TypeError
+        const result = await sendViaEmail(reqData, executorUser as any);
+
+        expect(result.missing).to.include('user_empty_emails');
+        expect(result.missing).to.include('user_no_emails');
+        expect(result.missing).to.not.include('user_valid');
+
+        expect(mailerMock.send.calledOnce).to.be.true;
+        const sendArgs = mailerMock.send.firstCall.args[0];
+
+        expect(sendArgs.to).to.deep.equal(['extra@example.com', 'valid@example.com']);
+    });
+});

apps/meteor/server/lib/dataExport/sendViaEmail.ts

@@ -29,7 +29,7 @@ export async function sendViaEmail(
 			projection: { 'username': 1, 'emails.address': 1 },
 		}).toArray()
 	).forEach((user: IUser) => {
-		const emailAddress = user.emails?.[0].address;
+		const emailAddress = user.emails?.[0]?.address;
 
 		if (!emailAddress) {
 			return;
@@ -67,9 +67,8 @@ export async function sendViaEmail(
 	)
 		.map((message: IMessage) => {
 			const dateTime = moment(message.ts).locale(lang).format('L LT');
-			return `<p style='margin-bottom: 5px'><b>${
-				message.u.username
-			}</b> <span style='color: #aaa; font-size: 12px'>${dateTime}</span><br/>${Message.parse(message, data.language)}</p>`;
+			return `<p style='margin-bottom: 5px'><b>${message.u.username
+				}</b> <span style='color: #aaa; font-size: 12px'>${dateTime}</span><br/>${Message.parse(message, data.language)}</p>`;
 		})
 		.join('');