Skip to content

fix: Markdown breaking issue between hyperlinks #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Giridharan002 wants to merge 4 commits into from
Closed

fix: Markdown breaking issue between hyperlinks #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4137aab
Implemented conversion of plain text in brackets to non-link format
Giridharan002 Jan 10, 2024
a1d0291
Merge branch 'main' into main
Giridharan002 Jan 10, 2024
23741d8
Merge branch 'RocketChat:main' into main
Giridharan002 Jan 21, 2024
4bfc923
Merge branch 'main' into main
Giridharan002 Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/message-parser/src/grammar.pegjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
strike,
task,
tasks,
unnest,
unorderedList,
} = require('./utils');
}}
Expand Down Expand Up @@ -227,8 +228,10 @@ InlineItem = Whitespace
*
*/
References
= "[" title:LinkTitle* "](" href:LinkRef ")" { return title.length ? link(href, reducePlainTexts(title)) : link(href); }
= "[" title:LinkTitle* "](" href:LinkRef ")" { return title.length ? link(href, reducePlainTexts(flatten(title))) : link(href); }
/ "<" href:LinkRef "|" title:LinkTitle2 ">" { return link(href, [plain(title)]); }
LinkTitle = (Whitespace / Emphasis) / balanced / anyTitle:$[^\[\]] { return plain(anyTitle) }
balanced = "[" t:LinkTitle* "]" { return reducePlainTexts([plain("["), ...(t || []), plain("]")]) }

LinkTitle = (Whitespace / EmphasisForReferences) / anyTitle:$(!("](" .) .) { return plain(anyTitle) }

Expand Down
8 changes: 8 additions & 0 deletions packages/message-parser/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,14 @@ const joinEmoji = (

return current;
};
export const unnest = (inputValues: Paragraph['value']): Paragraph['value'] =>
inputValues.reduce(
(accumulator, currentValue) => [
...accumulator,
...(Array.isArray(currentValue) ? currentValue : [currentValue]),
],
[] as Paragraph['value']
);

export const reducePlainTexts = (
values: Paragraph['value']
Expand Down