Skip to content

fix(fuselage): SelectAria id prop overwriting#1533

Merged
juliajforesti merged 4 commits intomainfrom
fix/select-aria
Jan 23, 2025
Merged

fix(fuselage): SelectAria id prop overwriting#1533
juliajforesti merged 4 commits intomainfrom
fix/select-aria

Conversation

@juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

After react-aria bump the id prop was being overwritten causing an infinite loop

Issue(s)

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 5e17925

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliajforesti juliajforesti marked this pull request as ready for review January 22, 2025 17:15
@dougfabris dougfabris changed the title fix: SelectAria id prop overwriting fix(fuselage): SelectAria id prop overwriting Jan 22, 2025
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliajforesti juliajforesti merged commit a5bc3a6 into main Jan 23, 2025
5 checks passed
@juliajforesti juliajforesti deleted the fix/select-aria branch January 23, 2025 15:07
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants