Skip to content

fix(fuselage): ensure MultiSelect dropdown closes on addon click #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vrund4591 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(fuselage): ensure MultiSelect dropdown closes on addon click #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a8dd88
fix(fuselage): ensure MultiSelect dropdown closes on addon click
Vrund4591 Jan 2, 2026
a82cf4e
chore: add changeset
Vrund4591 Jan 2, 2026
a430c91
Merge branch 'main' into fix/multiselect-dropdown-close
Vrund4591 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sour-zoos-help.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/fuselage': patch
---

fix: ensure MultiSelect dropdown closes on addon click
11 changes: 9 additions & 2 deletions packages/fuselage/src/components/MultiSelect/MultiSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,20 +144,25 @@ const MultiSelect = forwardRef<HTMLInputElement, MultiSelectProps>(
return show();
});

const handleAddonClick = useEffectEvent((e: SyntheticEvent) => {
e.stopPropagation();
e.preventDefault();
handleClick();
});

return (
<Box
is='div'
rcx-select
className={[error && 'invalid', disabled && 'disabled']}
ref={containerRef}
onClick={handleClick}
disabled={disabled}
{...props}
>
<FlexItem grow={1}>
<Margins inline='x4'>
<FlexContainer>
<Box is='div'>
<Box is='div' onClick={handleClick}>
<Box
is='div'
display='flex'
Expand Down Expand Up @@ -216,6 +221,8 @@ const MultiSelect = forwardRef<HTMLInputElement, MultiSelectProps>(
<FlexItem grow={0} shrink={0}>
<Margins inline='x4'>
<SelectAddon
onMouseDown={(e) => e.preventDefault()}
onClick={handleAddonClick}
children={
<Icon
name={
Expand Down