Skip to content

fix: utilize room state for kick validation #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 1 commit into from
Mar 10, 2026
Merged

fix: utilize room state for kick validation #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions packages/federation-sdk/src/services/room.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
RoomVersion,
UserID,
extractDomainFromId,
getStateByMapKey,
} from '@rocket.chat/federation-room';
import { delay, inject, singleton } from 'tsyringe';

Expand Down Expand Up @@ -557,20 +558,15 @@ export class RoomService {

const roomInfo = await this.stateService.getRoomInformation(roomId);

const authEventIdsForPowerLevels = await this.eventService.getAuthEventIds('m.room.power_levels', { roomId, senderId });
const powerLevelsEventId = this.getEventByType(authEventIdsForPowerLevels, 'm.room.power_levels')?._id;

if (!powerLevelsEventId) {
// Use resolved room state for power level (same state used when building the kick event's auth_events).
const state = await this.stateService.getLatestRoomState(roomId);
const powerLevelsEvent = getStateByMapKey(state, { type: 'm.room.power_levels' });
if (!powerLevelsEvent?.isPowerLevelEvent?.()) {
logger.warn(`No power_levels event found for room ${roomId}, cannot verify permission to kick.`);
throw new HttpException('Cannot verify permission to kick user.', HttpStatus.FORBIDDEN);
}
const powerLevelsEvent = await this.eventService.getEventById(powerLevelsEventId, 'm.room.power_levels');
if (!powerLevelsEvent) {
logger.error(`Power levels event ${powerLevelsEventId} not found despite ID being retrieved.`);
throw new HttpException('Internal server error: Power levels event data missing.', HttpStatus.INTERNAL_SERVER_ERROR);
}

this.validateKickPermission(powerLevelsEvent.event.content, senderId, kickedUserId);
this.validateKickPermission(powerLevelsEvent.getContent(), senderId, kickedUserId);

const kickEvent = await this.stateService.buildEvent<'m.room.member'>(
{
Expand Down