Skip to content

BUG: fins failing to accept both sweep and angle #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabrielBarberini merged 3 commits into from
Oct 10, 2025
Merged

BUG: fins failing to accept both sweep and angle #59

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25a8178
BUG: temp accepting length only.
aasitvora99 Oct 4, 2025
60a7aea
ENH: add sweep_angle to Fins model and refactor get_additional_parame…
aasitvora99 Oct 9, 2025
57e0159
linter sanity
GabrielBarberini Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/models/sub/aerosurfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,17 @@ class Fins(BaseModel):
sweep_length: Optional[float] = None
sweep_angle: Optional[float] = None

_base_keys = {"fins_kind", "name", "n", "root_chord", "span", "position"}

def get_additional_parameters(self):
return {
key: value
for key, value in self.dict().items()
if value is not None
and key
not in ["fins_kind", "name", "n", "root_chord", "span", "position"]
params = {
k: v for k, v in self.dict().items()
if v is not None and k not in self._base_keys
}
if "sweep_angle" in params and "sweep_length" in params:
params.pop("sweep_length")

return params


# TODO: implement airbrakes
Expand Down
Loading