Skip to content

Conversation

LUCKIN13
Copy link
Contributor

@LUCKIN13 LUCKIN13 commented Aug 8, 2025

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

New behavior

With this small change it is possible to use ensemble files from ERA5 database, which might be usefull for Monte Carlo Simulations.

Enter text here...

Breaking change

  • Yes
  • No

@LUCKIN13 LUCKIN13 requested a review from a team as a code owner August 8, 2025 16:56
@Gui-FernandesBR
Copy link
Member

  1. @LUCKIN13 , it is critical that we run slow tests before merging this PR
  2. Do you think we could update the documentation to clearly state to the users they can now use this feature?
  3. The CHANGELOG needs to be updated.

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (f17893b) to head (6d10f1a).
⚠️ Report is 18 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #842    +/-   ##
=========================================
  Coverage    80.02%   80.02%            
=========================================
  Files           98      103     +5     
  Lines        12004    12527   +523     
=========================================
+ Hits          9606    10025   +419     
- Misses        2398     2502   +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LUCKIN13
Copy link
Contributor Author

LUCKIN13 commented Aug 8, 2025

  1. @LUCKIN13 , it is critical that we run slow tests before merging this PR
  2. Do you think we could update the documentation to clearly state to the users they can now use this feature?
  3. The CHANGELOG needs to be updated.

Will do all that asap

@LUCKIN13
Copy link
Contributor Author

All slow tests passed.
Funny thing is that this possibility was already in the documentation, even though the ECMWF dictionary didn't have the ensemble parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants