-
-
Notifications
You must be signed in to change notification settings - Fork 237
FEAT/Rail Button Bending Moments #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT/Rail Button Bending Moments #901
Conversation
…f 15mm and updated the docstring
|
@Gui-FernandesBR Apologies for PR #900. It accidentally included unrelated commits. I have since closed it. Regarding your rail button height concern: I've added a |
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind updataing flight_plots and/or flight_prints too? including these values to the .info() or .all_info() outputs would be key here.
@Monta120 did you left any comment about this in the code? Ensure users can read about your assumptions or any simplification. |
Just added detailed comments in the docstring explaining the simple support assumption (no moment reaction at rail contact), beam theory approach, and both moment contributions (normal force × distance + shear force × height). Also documented and explained in Flight.rst. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #901 +/- ##
===========================================
+ Coverage 80.27% 80.77% +0.50%
===========================================
Files 104 107 +3
Lines 12769 13374 +605
===========================================
+ Hits 10250 10803 +553
- Misses 2519 2571 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is also taken care of as of the last commit. |
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Flight class calculates rail button normal and shear forces during launch phase but does not compute bending moments at attachment points. This data is needed for structural analysis of airframe and fasteners. See #893.
New behavior
Adds bending moment calculation using beam theory:
New Flight attributes:
rail_button1_bending_moment(Function): Upper button bending moment (N⋅m)max_rail_button1_bending_moment(float): Max absolute upper momentrail_button2_bending_moment(Function): Lower button bending moment (N⋅m)max_rail_button2_bending_moment(float): Max absolute lower momentFormula:
M = N × d_CM + S × h_buttonwhere:N: Normal reaction force,d_CM: distance to center of dry massS: Shear force,h_button: button height (cantilever moment)Unit tests verify non-zero moments with off-axis forces and zero otherwise. Updated Flight.rst docs and CHANGELOG.md.
Breaking change
Additional information
button_heightattribute to RailButtons class (default: None) for cantilever moment calculation (S × h)