Skip to content

chore: separated the attribute generator from the source generated from having attributes #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RLittlesII wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: separated the attribute generator from the source generated from having attributes #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/Defaults/Generator/DefaultsAttributeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
using Microsoft.CodeAnalysis;

namespace Rocket.Surgery.Airframe.Defaults.Generator;

/// <summary>
/// This class generates the attributes required to opt in to defaults.
/// </summary>
[Generator]
internal class DefaultsAttributeGenerator : IIncrementalGenerator
{
/// <inheritdoc/>
public void Initialize(IncrementalGeneratorInitializationContext context)
{
RegisterDefaultAttribute(context);

void RegisterDefaultAttribute(IncrementalGeneratorInitializationContext incrementalContext) => incrementalContext.RegisterPostInitializationOutput(
initializationContext => initializationContext.AddSource($"{nameof(DefaultsAttribute)}.g.cs", DefaultsAttribute.Source));
}
}
4 changes: 0 additions & 4 deletions src/Defaults/Generator/DefaultsGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ internal partial class DefaultsGenerator : IIncrementalGenerator
public void Initialize(IncrementalGeneratorInitializationContext context)
{
RegisterDefaultsGenerator(context);
RegisterDefaultAttribute(context);

[SuppressMessage("ReSharper", "RedundantNameQualifier", Justification = "Source Generation")]
void RegisterDefaultsGenerator(IncrementalGeneratorInitializationContext incrementalContext)
Expand All @@ -30,9 +29,6 @@ void RegisterDefaultsGenerator(IncrementalGeneratorInitializationContext increme
incrementalContext.RegisterSourceOutput(syntaxProvider, GenerateDefaults);
}

void RegisterDefaultAttribute(IncrementalGeneratorInitializationContext incrementalContext) => incrementalContext.RegisterPostInitializationOutput(
initializationContext => initializationContext.AddSource($"{nameof(DefaultsAttribute)}.g.cs", DefaultsAttribute.Source));

void GenerateDefaults(SourceProductionContext productionContext, (GeneratorAttributeSyntaxContext SyntaxContext, Compilation Compilation) tuple)
{
var (syntaxContext, compilation) = tuple;
Expand Down
1 change: 1 addition & 0 deletions test/Defaults.Tests/Data/DefaultsSourceData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ internal abstract class DefaultsSourceData
protected static GeneratorTestContextBuilder DefaultBuilder() => GeneratorTestContextBuilder
.Create()
.WithGenerator<DefaultsGenerator>()
.WithGenerator<DefaultsAttributeGenerator>()
.IgnoreOutputFile("DefaultsAttribute.g.cs");

protected static GeneratorTestContextBuilder Rsad0001() => GeneratorTestContextBuilder
Expand Down
1 change: 1 addition & 0 deletions test/Defaults.Tests/Generator/DefaultsGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public async Task GivenAGenerator_WhenGenerate_ThenAttributeGenerated()
// Given, When
var result = await GeneratorTestContextBuilder
.Create()
.WithGenerator<DefaultsAttributeGenerator>()
.WithGenerator<DefaultsGenerator>()
.AddReferences(typeof(List<>))
.Build()
Expand Down
2 changes: 1 addition & 1 deletion ...Tests.GivenAGenerator_WhenGenerate_ThenAttributeGenerated#DefaultsAttribute.g.verified.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//HintName: Rocket.Surgery.Airframe.Defaults/Rocket.Surgery.Airframe.Defaults.Generator.DefaultsGenerator/DefaultsAttribute.g.cs
//HintName: Rocket.Surgery.Airframe.Defaults/Rocket.Surgery.Airframe.Defaults.Generator.DefaultsAttributeGenerator/DefaultsAttribute.g.cs
#nullable enable
using System;
using System.Diagnostics;
Expand Down
1 change: 1 addition & 0 deletions ...d/DefaultsGeneratorTests.GivenAGenerator_WhenGenerate_ThenAttributeGenerated.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
FinalDiagnostics: [],
GeneratorDiagnostics: {
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsAttributeGenerator: [],
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsGenerator: []
},
ParseOptions: {
Expand Down
18 changes: 18 additions & 0 deletions ...ferenceType_WhenGenerate_ThenDoesNotGenerateDefaultProperty_f0b315ce25864f73.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
FinalDiagnostics: [],
GeneratorDiagnostics: {
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsAttributeGenerator: [],
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsGenerator: []
},
ParseOptions: {
DocumentationMode: Parse
},
References: [
mscorlib.dll,
netstandard.dll,
System.Core.dll,
System.dll,
System.Private.CoreLib.dll,
System.Runtime.dll
]
}
18 changes: 18 additions & 0 deletions ...venAReferenceType_WhenGenerate_ThenGeneratesDefaultProperty_27106aaef6327bcd.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
FinalDiagnostics: [],
GeneratorDiagnostics: {
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsAttributeGenerator: [],
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsGenerator: []
},
ParseOptions: {
DocumentationMode: Parse
},
References: [
mscorlib.dll,
netstandard.dll,
System.Core.dll,
System.dll,
System.Private.CoreLib.dll,
System.Runtime.dll
]
}
18 changes: 18 additions & 0 deletions ...venAReferenceType_WhenGenerate_ThenGeneratesDefaultProperty_3874526b3a114d25.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
FinalDiagnostics: [],
GeneratorDiagnostics: {
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsAttributeGenerator: [],
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsGenerator: []
},
ParseOptions: {
DocumentationMode: Parse
},
References: [
mscorlib.dll,
netstandard.dll,
System.Core.dll,
System.dll,
System.Private.CoreLib.dll,
System.Runtime.dll
]
}
18 changes: 18 additions & 0 deletions ...venAReferenceType_WhenGenerate_ThenGeneratesDefaultProperty_790664344f2e13ca.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
FinalDiagnostics: [],
GeneratorDiagnostics: {
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsAttributeGenerator: [],
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsGenerator: []
},
ParseOptions: {
DocumentationMode: Parse
},
References: [
mscorlib.dll,
netstandard.dll,
System.Core.dll,
System.dll,
System.Private.CoreLib.dll,
System.Runtime.dll
]
}
18 changes: 18 additions & 0 deletions ...venAReferenceType_WhenGenerate_ThenGeneratesDefaultProperty_f24e0ebfe01aeda9.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
FinalDiagnostics: [],
GeneratorDiagnostics: {
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsAttributeGenerator: [],
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsGenerator: []
},
ParseOptions: {
DocumentationMode: Parse
},
References: [
mscorlib.dll,
netstandard.dll,
System.Core.dll,
System.dll,
System.Private.CoreLib.dll,
System.Runtime.dll
]
}
18 changes: 18 additions & 0 deletions ...venAReferenceType_WhenGenerate_ThenGeneratesDefaultProperty_f2c229c9ab5834cb.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
FinalDiagnostics: [],
GeneratorDiagnostics: {
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsAttributeGenerator: [],
Rocket.Surgery.Airframe.Defaults.Generator.DefaultsGenerator: []
},
ParseOptions: {
DocumentationMode: Parse
},
References: [
mscorlib.dll,
netstandard.dll,
System.Core.dll,
System.dll,
System.Private.CoreLib.dll,
System.Runtime.dll
]
}
Loading