Skip to content

Celery options to improve stability #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihow merged 6 commits into from
Nov 16, 2025
Merged

Celery options to improve stability #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
539417b
feat: test new celery option for auto canceling disconnected tasks
mihow Nov 16, 2025
ddc5e36
feat: try to better handle poor network connections
mihow Nov 16, 2025
b19ca04
chore: no longer using redis as broker
mihow Nov 16, 2025
34ce837
fix: move setting to proper place!
mihow Nov 16, 2025
c2c48a6
fix: use RabbitMQ for results backend locally & by default
mihow Nov 16, 2025
d6e5044
chore: bring back redis defaults, if a environment is using redis
mihow Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .envs/.ci/.django
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@ DEFAULT_PROCESSING_SERVICE_ENDPOINT=http://ml_backend:2000
# RabbitMQ
# ------------------------------------------------------------------------------
CELERY_BROKER_URL=amqp://rabbituser:rabbitpass@rabbitmq:5672/
CELERY_RESULT_BACKEND=rpc:// # Use RabbitMQ for results backend
RABBITMQ_DEFAULT_USER=rabbituser
RABBITMQ_DEFAULT_PASS=rabbitpass
1 change: 1 addition & 0 deletions .envs/.local/.django
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ CELERY_FLOWER_PASSWORD=BEQgmCtgyrFieKNoGTsux9YIye0I7P5Q7vEgfJD2C4jxmtHDetFaE2jhS

# RabbitMQ
CELERY_BROKER_URL=amqp://rabbituser:rabbitpass@rabbitmq:5672/
CELERY_RESULT_BACKEND=rpc:// # Use RabbitMQ for results backend
RABBITMQ_DEFAULT_USER=rabbituser
RABBITMQ_DEFAULT_PASS=rabbitpass

Expand Down
14 changes: 10 additions & 4 deletions config/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@
# https://docs.celeryq.dev/en/stable/userguide/configuration.html#std:setting-broker_url
CELERY_BROKER_URL = env("CELERY_BROKER_URL")
# https://docs.celeryq.dev/en/stable/userguide/configuration.html#std:setting-result_backend
CELERY_RESULT_BACKEND = env("CELERY_RESULT_BACKEND", default=env("REDIS_URL", default=None))
# "rpc://" means use RabbitMQ for results backend by default
CELERY_RESULT_BACKEND = env("CELERY_RESULT_BACKEND", default="rpc://") # type: ignore[no-untyped-call]
# https://docs.celeryq.dev/en/stable/userguide/configuration.html#result-extended
CELERY_RESULT_EXTENDED = True
# https://docs.celeryq.dev/en/stable/userguide/configuration.html#result-backend-always-retry
Expand Down Expand Up @@ -334,7 +335,8 @@
# https://docs.celeryq.dev/en/stable/userguide/configuration.html#std-setting-task_send_sent_event
CELERY_TASK_SEND_SENT_EVENT = True

# Health checking and retries, specific to Redis
# Health checking and retries if using Redis as results backend
# https://docs.celeryq.dev/en/stable/userguide/configuration.html#redis
CELERY_REDIS_MAX_CONNECTIONS = 50 # Total connection pool limit for results backend
CELERY_REDIS_SOCKET_TIMEOUT = 120 # Match Redis timeout
CELERY_REDIS_SOCKET_KEEPALIVE = True
Expand All @@ -346,15 +348,19 @@
CELERY_WORKER_PREFETCH_MULTIPLIER = 1
CELERY_WORKER_ENABLE_PREFETCH_COUNT_REDUCTION = True

# Cancel & return to queue if connection is lost
# https://docs.celeryq.dev/en/latest/userguide/configuration.html#worker-cancel-long-running-tasks-on-connection-loss
CELERY_WORKER_CANCEL_LONG_RUNNING_TASKS_ON_CONNECTION_LOSS = True

# RabbitMQ broker connection settings
# These settings improve reliability for long-running workers with intermittent network issues
CELERY_BROKER_TRANSPORT_OPTIONS = {
"socket_timeout": 120, # Socket read/write timeout (seconds)
"socket_connect_timeout": 30, # Max time to establish connection (seconds)
"socket_connect_timeout": 40, # Max time to establish connection (seconds)
"socket_keepalive": True, # Enable TCP keepalive probes
"retry_on_timeout": True, # Retry operations on timeout
"max_connections": 20, # Per-process connection pool limit
"heartbeat": 60, # RabbitMQ heartbeat interval (seconds) - detects broken connections
"heartbeat": 30, # RabbitMQ heartbeat interval (seconds) - detects broken connections
}

# Broker connection retry settings
Expand Down