Skip to content

Fix the "null" string in the station update form #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annavik merged 4 commits into from
Jan 15, 2026
Merged

Fix the "null" string in the station update form #1074

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f952ad
fix: don't send "null" as a string. treat it like undefined.
mihow Dec 6, 2025
b3400b7
fix: allow clearing the string fields
mihow Dec 6, 2025
8ae8617
fix: update types for deployment fields (allow null)
mihow Dec 6, 2025
28d1e30
fix: convert null to blank in form
mihow Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/components/filtering/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const stringToBoolean = (string?: string) => {
}

export const booleanToString = (value?: boolean) =>
value !== undefined ? `${value}` : ''
value !== undefined && value !== null ? `${value}` : ''

// Help function to decide if a filter section should be open or not on page load
export const someActive = (
Expand Down
2 changes: 1 addition & 1 deletion ui/src/data-services/hooks/deployments/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const convertToFormData = (fieldValues: DeploymentFieldValues) => {
longitude: fieldValues.longitude,
research_site_id: fieldValues.siteId,
}).forEach(([key, value]) => {
if (value !== undefined) {
if (value !== undefined && value !== null) {
data.append(key, `${value}`)
}
})
Expand Down
2 changes: 1 addition & 1 deletion ui/src/utils/getAppRoute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const getAppRoute = ({
keepSearchParams ? window.location.search : undefined
)
Object.entries(filters).forEach(([name, value]) => {
if (value !== undefined) {
if (value !== undefined && value !== null) {
searchParams.set(name, value)
}
})
Expand Down