Improvement: Fill gaps in history from HA#1064
Open
Triple-S wants to merge 1 commit intoRomRider:masterfrom
Open
Improvement: Fill gaps in history from HA#1064Triple-S wants to merge 1 commit intoRomRider:masterfrom
Triple-S wants to merge 1 commit intoRomRider:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I recently noticed that one of my series had gaps even though I had enabled the
fill_rawoption to fill gaps. Looking to the code I realized thatfill_rawonly works if the gap exists because the HA history reportsnull,undefined,unavailable, etc., but it does'nt work if the HA history simply reports nothing aka. an actual gap.This PR fixes this problem by simply scanning the reported history for actual gaps and filling any found gaps with null states which are then later taken care of by the
fill_rawlogic. This is safe because the HA history is not supposed to have gaps unless some sort of data corruption occurred.Bets regards,
Triple-S