Conversation
Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action) from 1.18.0 to 1.20.0. - [Release notes](https://github.com/ncipollo/release-action/releases) - [Commits](ncipollo/release-action@bcfe547...b7eabc9) --- updated-dependencies: - dependency-name: ncipollo/release-action dependency-version: 1.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 8.8.0 to 9.1.0. - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@e08c2b0...62c799d) --- updated-dependencies: - dependency-name: oxsecurity/megalinter dependency-version: 9.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 6.0.1 to 7.0.0. - [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases) - [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md) - [Commits](stefanzweifel/git-auto-commit-action@778341a...28e16e8) --- updated-dependencies: - dependency-name: stefanzweifel/git-auto-commit-action dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Added detailed comment blocks and improved documentation for all major PowerShell scripts and functions in Winget-AutoUpdate. Refactored code for clarity, standardized parameter usage, and improved error handling and logging. No functional changes, but code is now easier to maintain and understand.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…elop/ncipollo/release-action-1.20.0 Bump ncipollo/release-action from 1.18.0 to 1.20.0
…elop/actions/github-script-8 Bump actions/github-script from 7 to 8
…elop/actions/stale-10 Bump actions/stale from 9 to 10
…elop/oxsecurity/megalinter-9.1.0 Bump oxsecurity/megalinter from 8.8.0 to 9.1.0
…elop/stefanzweifel/git-auto-commit-action-7.0.0 Bump stefanzweifel/git-auto-commit-action from 6.0.1 to 7.0.0
DE locale fixes
Add documentation and refactor WAU PowerShell scripts
Fix incorrect mettered connection detected in Windows Server 2022
Implements support for passing additional winget-level parameters
per application using {AppID}-arguments.txt files in the mods/ folder.
Resolves #1073 (locale support)
Resolves #1075 (skip-dependencies support)
Changes:
- Added Parse-WingetArguments.ps1 function for robust argument parsing
- Updated Test-Mods.ps1 to detect -arguments.txt files
- Updated Update-App.ps1 to support ModsArguments with priority handling
- Updated Winget-Install.ps1 with corresponding logic
- Added _AppID-arguments-template.txt with comprehensive examples
- Updated documentation in README.md and mods/README.md
Priority order: Override > Custom > Arguments > Default"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…or Winget upgrades (and file wins over install parameters)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.8 to 7.0.9. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@271a8d0...84ae59a) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: 7.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 9.1.0 to 9.2.0. - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@62c799d...55a59b2) --- updated-dependencies: - dependency-name: oxsecurity/megalinter dependency-version: 9.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…elop/actions/checkout-6 Bump actions/checkout from 5 to 6
…elop/oxsecurity/megalinter-9.2.0 Bump oxsecurity/megalinter from 9.1.0 to 9.2.0
…elop/peter-evans/create-pull-request-7.0.9 Bump peter-evans/create-pull-request from 7.0.8 to 7.0.9
…elop/actions/upload-artifact-5 Bump actions/upload-artifact from 4 to 5
Add per-app winget arguments support via {AppID}-arguments.txt
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.9 to 8.0.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@84ae59a...98357b1) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…elop/actions/upload-artifact-6 Bump actions/upload-artifact from 5 to 6
…elop/peter-evans/create-pull-request-8.0.0 Bump peter-evans/create-pull-request from 7.0.9 to 8.0.0
There was a problem hiding this comment.
Pull request overview
This release includes significant refactoring and new features for Winget-AutoUpdate 2.9.0. The primary purpose is to improve code quality, add locale management for application updates, and introduce shortcut creation functionality.
Key Changes:
- Added support for
{AppID}-arguments.txtfiles to pass winget-level parameters (e.g.,--locale,--skip-dependencies) - Introduced
Add-ProgramsShortcutsfunction for creating Start Menu shortcuts from mods - Major refactoring of core functions with comprehensive help documentation
- Consolidated WiX registry key structure for cleaner installation
- Fixed German locale spelling errors
- Updated GitHub Actions dependencies to latest versions
Reviewed changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Wix/build.wxs | Consolidated registry keys into single RegistryKey block, reducing redundancy from 76 to 36 lines |
| Sources/Winget-AutoUpdate/mods/_Mods-Functions.ps1 | Added Add-ProgramsShortcuts function to create Start Menu shortcuts with target validation |
| Sources/Winget-AutoUpdate/mods/_AppID-template.ps1 | Added $Shortcuts/$ShortcutsTargets arrays for shortcut creation support |
| Sources/Winget-AutoUpdate/mods/_AppID-arguments-template.txt | New comprehensive template documenting winget-level argument usage with examples |
| Sources/Winget-AutoUpdate/mods/README.md | Expanded documentation for override/custom/arguments text file usage with priority order |
| Sources/Winget-AutoUpdate/locale/de.xml | Fixed German spelling: "Internet Verbindung" → "Internetverbindung", "sie" → "Sie" (formal) |
| Sources/Winget-AutoUpdate/functions/Write-ToLog.ps1 | Refactored with help block, simplified ACL logic, improved code structure |
| Sources/Winget-AutoUpdate/functions/Update-WAU.ps1 | Added comprehensive help documentation, improved comments |
| Sources/Winget-AutoUpdate/functions/Update-StoreApps.ps1 | Added help block and improved comments |
| Sources/Winget-AutoUpdate/functions/Update-App.ps1 | Major refactoring: 201→115 lines, added Get-WingetParams helper, improved argument handling |
| Sources/Winget-AutoUpdate/functions/Test-WAUMods.ps1 | Added comprehensive help documentation for action-based mod responses |
| Sources/Winget-AutoUpdate/functions/Test-PendingReboot.ps1 | Refactored with early returns, added help block |
| Sources/Winget-AutoUpdate/functions/Test-Network.ps1 | Improved metered detection, added help block, simplified control flow |
| Sources/Winget-AutoUpdate/functions/Test-ModsPath.ps1 | Enhanced comments, improved variable naming, added comprehensive help block |
| Sources/Winget-AutoUpdate/functions/Test-Mods.ps1 | Refactored to return Arguments parameter (8 values instead of 7), added arguments.txt support |
| Sources/Winget-AutoUpdate/functions/Test-ListPath.ps1 | Simplified with ternary-style conditionals, improved SAS token handling |
| Sources/Winget-AutoUpdate/functions/Start-NotifTask.ps1 | Added comprehensive help block with all parameters documented |
| Sources/Winget-AutoUpdate/functions/Invoke-LogRotation.ps1 | Enhanced help documentation, improved comments |
| Sources/Winget-AutoUpdate/functions/Install-Prerequisites.ps1 | Added help block, improved structure and comments |
| Sources/Winget-AutoUpdate/functions/Get-WingetSystemApps.ps1 | Added help block documenting system app export functionality |
| Sources/Winget-AutoUpdate/functions/Get-WingetOutdatedApps.ps1 | Fixed typo "recieving"→"receiving", added comprehensive help |
| Sources/Winget-AutoUpdate/functions/Get-WingetCmd.ps1 | Refactored with try/catch, simplified logic, added help block |
| Sources/Winget-AutoUpdate/functions/Get-WAUConfig.ps1 | Simplified GPO logic, improved readability, added help block |
| Sources/Winget-AutoUpdate/functions/Get-WAUAvailableVersion.ps1 | Added help block explaining pre-release vs stable version detection |
| Sources/Winget-AutoUpdate/functions/Get-NotifLocale.ps1 | Added help block, improved comments |
| Sources/Winget-AutoUpdate/functions/Get-IncludedApps.ps1 | Refactored with help block, simplified logic, fixed "Successsfully" typo |
| Sources/Winget-AutoUpdate/functions/Get-ExcludedApps.ps1 | Refactored with help block, simplified logic, fixed "Successsfully" typo |
| Sources/Winget-AutoUpdate/functions/Get-AppInfo.ps1 | Added comprehensive help documentation |
| Sources/Winget-AutoUpdate/functions/Get-AZCopy.ps1 | Added help block, improved comments throughout |
| Sources/Winget-AutoUpdate/functions/ConvertTo-WingetArgumentArray.ps1 | New function to parse winget arguments respecting quotes and spaces |
| Sources/Winget-AutoUpdate/functions/Confirm-Installation.ps1 | Simplified to single-expression return, added help block |
| Sources/Winget-AutoUpdate/functions/Compare-SemVer.ps1 | Added comprehensive help with pre-release comparison documentation |
| Sources/Winget-AutoUpdate/functions/Add-ScopeMachine.ps1 | Enhanced help and comments for WinGet settings configuration |
| Sources/Winget-AutoUpdate/config/WAU-MSI_Actions.ps1 | Refactored task creation logic, improved structure, added help block |
| Sources/Winget-AutoUpdate/Winget-Install.ps1 | Added arguments.txt support with ConvertTo-WingetArgumentArray |
| Sources/Winget-AutoUpdate/WAU-Policies.ps1 | Improved help block, enhanced comments |
| Sources/Winget-AutoUpdate/WAU-Notify.ps1 | Added help block explaining notification display process |
| Sources/Winget-AutoUpdate/User-Run.ps1 | Improved help block and comments |
| README.md | Extensive documentation for arguments.txt feature with locale tips and examples |
| .github/workflows/*.yml | Updated GitHub Actions versions: checkout@v6, release-action@v1.20.0, github-script@v8, megalinter@v9.2.0, stale@v10 |
| Return $removedCount | ||
| } | ||
|
|
||
| function Add-ProgramsShortcuts ($Shortcuts, $ShortcutsTargets) { |
There was a problem hiding this comment.
The Add-ProgramsShortcuts function lacks parameter documentation in a help block. Consider adding a comment-based help block with .SYNOPSIS, .DESCRIPTION, .PARAMETER, and .EXAMPLE sections to match the documentation style used in other functions throughout this codebase.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@Romanitho I've opened a new pull request, #1093, to work on those changes. Once the pull request is ready, I'll request review from you. |
❌MegaLinter analysis: Error
Detailed Issues❌ REPOSITORY / gitleaks - 2 errorsLinter output file not found
|
Updated image syntax in README.md for proper rendering.

Release 2.9.0
This PR is automatically created to perform the final tests and validations before the release is created.