Skip to content

Conversation

@Romanitho
Copy link
Owner

ServiceUI.exe is now added directly to the repository, eliminating the need to download and install Microsoft Deployment Toolkit (MDT), which has been decommissioned by Microsoft. The build workflow is updated to reflect this change, simplifying the build process and reducing external dependencies.

ServiceUI.exe is now added directly to the repository, eliminating the need to download and install Microsoft Deployment Toolkit (MDT), which has been decommissioned by Microsoft. The build workflow is updated to reflect this change, simplifying the build process and reducing external dependencies.
Copilot AI review requested due to automatic review settings January 17, 2026 00:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR eliminates the external dependency on Microsoft Deployment Toolkit (MDT) by including the ServiceUI.exe binary directly in the source repository. MDT has been decommissioned by Microsoft, making this change necessary to ensure build reliability.

Changes:

  • Added ServiceUI.exe binary (from MDT) directly to Sources/Winget-AutoUpdate/
  • Removed MDT download/install steps from GitHub Actions workflows
  • Updated workflow comments to reflect that ServiceUI.exe is now sourced locally
  • Fixed trailing whitespace in workflow files

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
Sources/Winget-AutoUpdate/ServiceUI.exe Added ServiceUI.exe binary file (391 lines/~150KB) directly to repository to eliminate MDT dependency
.github/workflows/GitFlow_Nightly-builds.yml Removed MDT download/install steps; updated comments; cleaned up trailing whitespace
.github/workflows/GitFlow_Make-Release-and-Sync-to-Dev.yml Removed MDT download/install steps; updated comments to indicate ServiceUI.exe is now in source

@github-actions
Copy link
Contributor

MegaLinter analysis: Error

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 2.32s
✅ POWERSHELL powershell 1 0 0 2.08s
✅ POWERSHELL powershell_formatter 1 0 0 1.39s
⚠️ REPOSITORY checkov yes 3 no 12.48s
⚠️ REPOSITORY devskim yes 1 8 1.39s
✅ REPOSITORY dustilock yes no no 0.01s
❌ REPOSITORY gitleaks yes 2 no 0.76s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 27.91s
✅ REPOSITORY kics yes no no 1.38s
✅ REPOSITORY kingfisher yes no no 3.58s
✅ REPOSITORY secretlint yes no no 0.48s
✅ REPOSITORY syft yes no no 1.05s
✅ REPOSITORY trivy yes no no 5.67s
✅ REPOSITORY trivy-sbom yes no no 0.11s
✅ REPOSITORY trufflehog yes no no 2.2s
⚠️ SPELL cspell 2 7 0 3.62s

Detailed Issues

❌ REPOSITORY / gitleaks - 2 errors

Linter output file not found

⚠️ REPOSITORY / checkov - 3 errors

Linter output file not found

⚠️ SPELL / cspell - 7 errors

Linter output file not found

⚠️ REPOSITORY / devskim - 1 error

Linter output file not found

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Romanitho Romanitho merged commit 6fbb56d into develop Jan 17, 2026
1 of 2 checks passed
@Romanitho Romanitho deleted the feature-serviceui branch January 17, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant