Skip to content

Feature/uninstallers #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Romanitho merged 3 commits into from
Apr 20, 2025
Merged

Feature/uninstallers #916

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0c4448
Wise Solutions
KnifMelti Apr 18, 2025
ab066fc
Space
KnifMelti Apr 18, 2025
9439803
Comment, clean and remove
KnifMelti Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 23 additions & 21 deletions Sources/Winget-AutoUpdate/mods/_Mods-Functions.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ Function Get-InstalledSoftware() {
foreach ($obj in $InstalledSoftware) {
if ($obj.GetValue('DisplayName') -like $App) {
$UninstallString = $obj.GetValue('UninstallString')
$CleanedUninstallString = $UninstallString.Trim([char]0x0022)
$CleanedUninstallString = $UninstallString.Replace('"', '')
$ExeString = $CleanedUninstallString.Substring(0, $CleanedUninstallString.IndexOf('.exe') + 4)
if ($UninstallString -like "MsiExec.exe*") {
$ProductCode = Select-String "{.*}" -inputobject $UninstallString
$ProductCode = $ProductCode.matches.groups[0].value
Expand All @@ -98,41 +99,42 @@ Function Get-InstalledSoftware() {
else {
$QuietUninstallString = $obj.GetValue('QuietUninstallString')
if ($QuietUninstallString) {
$QuietUninstallString = Select-String "(\x22.*\x22) +(.*)" -inputobject $QuietUninstallString
$QuietUninstallString = Select-String '("[^"]*") +(.*)' -inputobject $QuietUninstallString
$Command = $QuietUninstallString.matches.groups[1].value
$Parameter = $QuietUninstallString.matches.groups[2].value
# All EXE Installers (already defined silent uninstall)
Start-Process $Command -ArgumentList $Parameter -Wait
}
else {
# Improved detection logic
if ((Test-Path $CleanedUninstallString -ErrorAction SilentlyContinue)) {
if ((Test-Path $ExeString -ErrorAction SilentlyContinue)) {
try {
# Read the whole file to find installer signatures
$fileContent = Get-Content -Path $CleanedUninstallString -Raw -ErrorAction Stop
$fileContent = Get-Content -Path $ExeString -Raw -ErrorAction Stop
# Executes silent uninstallation based on installer type
if ($fileContent -match "\bNullsoft\b" -or $fileContent -match "\bNSIS\b") {
# NSIS Installer
Start-Process $UninstallString -ArgumentList "/NCRC /S" -Wait
# Nullsoft (NSIS) Uninstaller
Start-Process $ExeString -ArgumentList "/NCRC /S" -Wait
}
elseif ($fileContent -match "\bInno Setup\b") {
# Inno Installer
Start-Process $UninstallString -ArgumentList "/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP-" -Wait
# Inno Uninstaller
Start-Process $ExeString -ArgumentList "/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP-" -Wait
}
<# # More installation engines goes here
elseif ($fileContent -match "\bInstallShield\b") {
# InstallShield
Start-Process $UninstallString -ArgumentList "/s" -Wait
elseif ($fileContent -match "\bWise Solutions\b") {
# Wise Uninstaller (Unwise32.exe)
# Find the Install.log path parameter in the UninstallString
$ArgString = $CleanedUninstallString.Substring($CleanedUninstallString.IndexOf('.exe') + 4).Trim()
# Copy files to temp folder so that Unwise32.exe can find Install.log (very, very old system)
Copy-Item -Path $ExeString -Destination $env:TEMP -Force
$ExeString = Join-Path $env:TEMP (Split-Path $ExeString -Leaf)
Copy-Item -Path $ArgString -Destination $env:TEMP -Force
$ArgString = Join-Path $env:TEMP (Split-Path $ArgString -Leaf)
# Execute the uninstaller with the copied Unwise32.exe
Start-Process $ExeString -ArgumentList "/s $ArgString" -Wait
# Remove the copied Unwise32.exe from temp folder (Install.log gets deleted by Unwise32.exe)
Remove-Item -Path $ExeString -Force -ErrorAction SilentlyContinue
}
elseif ($fileContent -match "\bWise Installation Wizard\b") {
# Wise Installer
Start-Process $UninstallString -ArgumentList "/s" -Wait
}
elseif ($fileContent -match "\bAdvanced Installer\b") {
# Advanced Installer
Start-Process $UninstallString -ArgumentList "/quiet" -Wait
}
#> else {
else {
Write-Host "$(if($true -eq $x64) {'x64'} else {'x86'}) Uninstaller unknown, trying the UninstallString from registry..."
$NativeUninstallString = Select-String "(\x22.*\x22) +(.*)" -inputobject $UninstallString
$Command = $NativeUninstallString.matches.groups[1].value
Expand Down
Loading