Skip to content

Conversation

@KnifMelti
Copy link
Contributor

Proposed Changes

It now handles all relevant mods:
$ModsPreInstall, $ModsOverride, $ModsCustom, $ModsInstall, $ModsInstalled
$ModsPreUninstall, $ModsUninstall, $ModsUninstalled

Related Issues

#810

@github-actions github-actions bot added the invalid-branch Invalid branch label Apr 23, 2025
@KnifMelti KnifMelti changed the base branch from main to develop April 23, 2025 20:33
@github-actions github-actions bot removed the invalid-branch Invalid branch label Apr 23, 2025
@KnifMelti KnifMelti marked this pull request as ready for review April 23, 2025 20:57
@KnifMelti
Copy link
Contributor Author

@Romanitho I think I got it all, could you also test?

@KnifMelti KnifMelti marked this pull request as draft April 24, 2025 03:54
@KnifMelti
Copy link
Contributor Author

But all this interferes with #895 wouldn't it be better if @FaserF implemented this too?

@FaserF
Copy link
Contributor

FaserF commented Apr 24, 2025

You mean removing the ExitCode detection from my PR and integrate this changes from this PR into my PR too?

@KnifMelti
Copy link
Contributor Author

You mean removing the ExitCode detection from my PR and integrate this changes from this PR into my PR too?

No not removing and so, but since you already have a PR going.. ..but if you can update yours without problem if I PR this then it's fine!
I'll go along then and make the final adjustment and test some more then I'll make this ready for review.
Tonight, working now.

@KnifMelti KnifMelti marked this pull request as ready for review April 24, 2025 15:19
@KnifMelti KnifMelti marked this pull request as draft April 25, 2025 23:48
@KnifMelti KnifMelti marked this pull request as ready for review April 26, 2025 00:12
@KnifMelti KnifMelti marked this pull request as draft April 26, 2025 07:52
@KnifMelti KnifMelti closed this Apr 26, 2025
@KnifMelti KnifMelti deleted the feature/winget-install branch April 26, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants