Fix type instability with high thread counts#1
Open
ChrisRackauckas wants to merge 4 commits intoRomeoV:mainfrom
Open
Fix type instability with high thread counts#1ChrisRackauckas wants to merge 4 commits intoRomeoV:mainfrom
ChrisRackauckas wants to merge 4 commits intoRomeoV:mainfrom
Conversation
This commit fixes a critical bug that occurs when using more than 64 threads.
The change from CPUSummary.sys_threads() to Threads.nthreads() introduced
a type instability where worker_bits() and worker_mask_count() would return
regular Int instead of StaticInt types with high thread counts.
Changes:
- Modified worker_bits() to always return Int for consistency
- Updated worker_mask_count() to use regular integer division
- Added new _request_threads method that handles Int parameter
- Added test for high thread count compatibility
The fix maintains backward compatibility while ensuring the code works
correctly with any number of threads.
Fixes the MethodError: no method matching _request_threads(::UInt32, ::Ptr{UInt64}, ::Int64, ::Nothing)
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical type instability bug that was introduced when replacing
CPUSummary.sys_threads()withThreads.nthreads()in PR JuliaSIMD#28.The Problem
With the current implementation, when using more than 64 threads:
worker_bits()returns a regularInt64instead ofStaticIntworker_mask_count()which also returnsInt64_request_threadsfunction expectsStaticInt{N}but receivesInt64, causing aMethodErrorThe Solution
This PR makes the following changes:
worker_bits()to always returnIntfor consistencyworker_mask_count()to use regular integer division (cld)_request_threadsmethod that handlesIntparametersTesting
The fix has been tested with:
Before the fix:
After the fix:
Compatibility
The fix maintains backward compatibility while ensuring the code works correctly with any number of threads.
🤖 Generated with Claude Code