Skip to content

Cleanup now that we're using Vercel#109

Merged
mrubens merged 1 commit intomainfrom
vercel
Apr 2, 2025
Merged

Cleanup now that we're using Vercel#109
mrubens merged 1 commit intomainfrom
vercel

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Apr 2, 2025

Important

Remove GitHub Pages deployment configurations and files now that Vercel is used for deployment.

  • GitHub Actions:
    • Removed pages.yml workflow file for GitHub Pages deployment.
  • Docusaurus Configuration:
    • Removed organizationName and projectName from docusaurus.config.ts as they are specific to GitHub Pages.
  • Misc:
    • Deleted .nojekyll file from static/ directory.

This description was created by Ellipsis for 8b2a303. It will automatically update as commits are pushed.

@vercel
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
roo-code-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 7:33pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 2, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8b2a303 in 39 seconds

More details
  • Looked at 78 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. docusaurus.config.ts:31
  • Draft comment:
    Removal of organizationName and projectName is appropriate for Vercel deployment. Ensure no residual code depends on these values.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure that no residual code depends on the removed values, which violates the rule against asking the author to double-check things. It doesn't provide a specific suggestion or point out a specific issue.
2. .github/workflows/pages.yml:1
  • Draft comment:
    Deletion of the GitHub Pages deployment workflow file is correct given the switch to Vercel. Confirm that Vercel config is fully set up.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. .github/workflows/pages.yml:1
  • Draft comment:
    Removal of GitHub Pages workflow is appropriate for Vercel deployment. Ensure all required deployment configs have been migrated.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. static/.nojekyll:1
  • Draft comment:
    Deleting the .nojekyll file is fine if GitHub Pages is no longer used. Confirm there are no dependencies on it elsewhere.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. docusaurus.config.ts:29
  • Draft comment:
    Removal of 'organizationName' and 'projectName' is clean and fits Vercel deployment needs. Consider updating related comments if GitHub Pages references persist.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_9Q4AXD9kAdujbJ8P


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mrubens mrubens merged commit b104dbe into main Apr 2, 2025
3 checks passed
@mrubens mrubens deleted the vercel branch April 2, 2025 19:33
@dosubot dosubot bot added the documentation Improvements or additions to documentation label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant